Skip to content

Tweak Open Collective things - #137

Merged
vweevers merged 9 commits into
masterfrom
tweak-opencollective
Jan 5, 2019
Merged

Tweak Open Collective things#137
vweevers merged 9 commits into
masterfrom
tweak-opencollective

Conversation

@vweevers

@vweevers vweevers commented Jan 5, 2019

Copy link
Copy Markdown
Member

No description provided.

@vweevers
vweevers requested a review from ralphtheninja January 5, 2019 19:08
Comment thread README.md
@vweevers

vweevers commented Jan 5, 2019

Copy link
Copy Markdown
Member Author

Lemme try running hallmark on the readme too, to update the TOC and validate the markdown, though I'm expecting the HTML anchors to cause problems.

@vweevers

vweevers commented Jan 5, 2019

Copy link
Copy Markdown
Member Author

Oh, and get rid of CONTRIBUTING.md? Missed that one.

@vweevers

vweevers commented Jan 5, 2019

Copy link
Copy Markdown
Member Author

though I'm expecting the HTML anchors to cause problems.

Yup. Markdown links to HTML anchors are rejected by remark-validate-links .Options:

  1. Use HTML links when linking to HTML anchors. E.g. <a href="#ctor"><code><b>level()</b></code></a>. It means these links won't be validated, but at least the rest of the markdown will.
  2. Adapt remark-validate-links to parse HTML anchors. Probably difficult because remark does not parse HTML, it's just a text node in the AST.

I prefer 1.

@vweevers
vweevers merged commit 522f43f into master Jan 5, 2019
@vweevers
vweevers deleted the tweak-opencollective branch January 5, 2019 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants