Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: vpulim/node-soap
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: La-source/node-soap
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 1 file changed
  • 2 contributors

Commits on Oct 1, 2015

  1. Fixed problem with converting objects inside $value

    
    ```
    {
        "exampleAction": {
            "simpleParam1": {
                "$value": "abc",
                "attributes": {
                    "xmlns": ""
                }
            },
            "simpleParam2": {
                "$value": "xyz",
                "attributes": {
                    "xmlns": ""
                }
            },
            "arrayParam": {
                "$value": {
                    "propArray": [
                        {
                            "name": "prop1",
                            "value": "123"
                        },
                        {
                            "name": "prop2",
                            "value": "789"
                        }
                    ]
                },
                "attributes": {
                    "xmlns": ""
                }
            }
        }
    }
    ```
    
    Before: would convert to:
    ```
    <exampleAction xmlns="http://ws.example.net/">
    	<simpleParam1 xmlns="">abc</simpleParam1>
    	<simpleParam2 xmlns="">xyz</simpleParam2>
    	<arrayParam xmlns="">
    		[object Object]
    	</arrayParam>
    </exampleAction>
    ```
    
    After: would convert to (as expected)
    ```
    <exampleAction xmlns="http://ws.example.net/">
    	<simpleParam1 xmlns="">abc</simpleParam1>
    	<simpleParam2 xmlns="">xyz</simpleParam2>
    	<arrayParam xmlns="">
    		<propArray>
    			<name>prop1</name>
    			<value>123</value>
    		</propArray>
    		<propArray>
    			<name>prop2</name>
    			<value>789</value>
    		</propArray>
    	</arrayParam>
    </exampleAction>
    ```
    jadbaz committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    b05df52 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2015

  1. Configuration menu
    Copy the full SHA
    3e25994 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2018

  1. Merge remote-tracking branch 'jadbaz/master'

    # Conflicts:
    #	lib/wsdl.js
    PhilippeCaira committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    8d4ad18 View commit details
    Browse the repository at this point in the history
  2. Fix parameters name

    PhilippeCaira committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    2a38e0a View commit details
    Browse the repository at this point in the history
  3. Adapt $value array

    PhilippeCaira committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    9aef463 View commit details
    Browse the repository at this point in the history
Loading