Repository navigation
Проектная работа № 1. Гонки - #1
Open
KseniyaRyabitskaya wants to merge 5 commits into
Open
KseniyaRyabitskaya wants to merge 5 commits into
KseniyaRyabitskaya wants to merge 5 commits into
Conversation
Comment on lines
+2
to
+3
| String nameCar; | ||
| int speedCar; |
There was a problem hiding this comment.
Переменные лучше пометить final, чтобы не было возможности модифицировать их извне
|
|
||
| if (answer.equalsIgnoreCase("Завершить")) { | ||
| break; | ||
| ArrayList<Car> carList = new ArrayList<>(); |
There was a problem hiding this comment.
Можно не сохранять все машины в список, а считать и запоминать лидера прямо во время ввода пользователем данных, таким образом программа будет потреблять меньше памяти
|
|
||
| public class Race { | ||
|
|
||
| public static String winner(ArrayList<Car> carSet) { |
There was a problem hiding this comment.
В нейминге функций принято использовать глаголы, т.к. функция - это действие. Здесь хорошо подходит название calculateWinner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Проектная работа № 1. Гонки