Fixed the exceptions#410
Merged
cursedcoder merged 1 commit intoKnpLabs:masterfrom Jul 31, 2016
GrahamCampbell:exceptions
Merged
Fixed the exceptions#410cursedcoder merged 1 commit intoKnpLabs:masterfrom GrahamCampbell:exceptions
cursedcoder merged 1 commit intoKnpLabs:masterfrom
GrahamCampbell:exceptions
Conversation
3 tasks
Collaborator
|
I did not know that the exceptions thrown by the plugin must extend the httplug base exception. Maybe we should revisit the exceptions before 2.0? 👍 for this PR. |
Contributor
Author
|
Maybe, yeh. This PR is essential at the moment though. |
|
I am not 100% sure about this. I think your originally proposed solution was right. See php-http/client-common#34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a requirement that any exceptions thrown by plugins implement this interface.
Closes #409.