Updated the ManagementConsole class to reflect changes in the GitHub API#331
Closed
guillermoandrae wants to merge 6 commits intoKnpLabs:masterfrom
guillermoandrae:master
Closed
Updated the ManagementConsole class to reflect changes in the GitHub API#331guillermoandrae wants to merge 6 commits intoKnpLabs:masterfrom guillermoandrae:master
guillermoandrae wants to merge 6 commits intoKnpLabs:masterfrom
guillermoandrae:master
Conversation
Contributor
guillermoandrae
commented
Oct 24, 2015
guillermoandrae
commented
- ManagementConsole class now uses the management console password instead of the license hash
- Added setBaseUrl() method to the HttpClientInterface
- Refactored setEnterpriseUrl() and added a corresponding test
- Made some changes for PSR2 compliance
added 6 commits
October 24, 2015 11:35
Not checking test directory for standards (yet?).
…ace and HttpClient
…hentication documentation.
Contributor
Author
|
@GrahamCampbell I botched up the rebase on the #330, so I created a new PR. |
Contributor
There was a problem hiding this comment.
the method name getWithLicenseHash should be changed though (as it is protected, the existing name should also be kept but deprecated and forwarding to the new method), as it is not using a license hash anymore
Contributor
|
@guillermoandrae closing this right now because of merge issues, if you want to continue your great work please re-open it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.