Handle relative and case insensitive file paths - #191
Merged
Conversation
sparr
force-pushed
the
relative_caseinsensitive_paths
branch
from
July 4, 2023 16:06
dd433de to
01fbc08
Compare
Contributor
Author
|
Lots of unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a few problems I had exporting assets from the game Autonauts.
library/unity default assetswhich, in addition to being relative and case insensitive, also doesn't exist becauseLibrary/is apparently a magic path in Unity. Rather than calling that out explicitly here, I've opted to just silently ignore nonexistent paths/files.I wasn't able to test on Windows, which might have a problem with the case insensitive search.
PS: I also spotted a bug in
save()but can't test the fix I included here. Let me know if that's a problem and I can remove it.