Skip to content

BundleFile: fix exception on file.save("original") - #178

Merged
K0lb3 merged 1 commit into
K0lb3:masterfrom
astiob:save-original
Jun 4, 2023
Merged

BundleFile: fix exception on file.save("original")#178
K0lb3 merged 1 commit into
K0lb3:masterfrom
astiob:save-original

Conversation

@astiob

@astiob astiob commented Apr 15, 2023

Copy link
Copy Markdown
Contributor

Regression in commit 9232cdd (release 1.9.21), which renamed _data_flags to dataflags.

Regression in commit 9232cdd,
which renamed _data_flags to dataflags.
@astiob

astiob commented Apr 15, 2023

Copy link
Copy Markdown
Contributor Author

On a slightly related note (I’d open a separate GitHub issue, but it isn’t exactly a bug), save_fs should maybe throw if the data_flags argument includes the encryption flag, because (as far as I can tell) UnityPy doesn’t implement encryption upon saving. But this isn’t entirely trivial to implement because the argument may be passed as a raw integer, so you’d need to duplicate the version-dependent logic from read_fs just to figure out what the integer means.

@K0lb3

K0lb3 commented Jun 4, 2023

Copy link
Copy Markdown
Owner

Thanks for noticing and fixing the issue.
And you're right, it should error in case it's supposed to store an encrypted bundle.

@K0lb3
K0lb3 merged commit 6cdafe3 into K0lb3:master Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants