Breaking Change: Fix objects with the same container path - #172
Closed
t-wy wants to merge 2 commits into
Closed
Conversation
Reimplement the array of KeyValuePair (multi-dict) structure in AssetStudio as a list-of-tuple structure to address the issue of multiple objects with the same container path when implemented as dict. Breaking Part: All .items() call to .container or .m_Container is no longer needed as it is an array instead of a dict.
Owner
|
Sorry for the late reply. I "fixed" it in a test branch some time ago without breaking the normal usage pattern while still allowing it to pass through all keys and values. |
Contributor
Author
|
Thanks for the reply. I see the concern, especially when it comes to the compatbility issues. |
Owner
|
implemented by #186 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing the issue #45, referenced PR #134 and AssetStudio's original implementation.
Reimplemented the array of KeyValuePair (multi-dict) structure in AssetStudio as a list-of-tuple structure to address the issue of multiple objects with the same container path when implemented as dict, such that all objects return the expected .container str value instead of None.
The tuple ((path, obj)) may be changed to a list ([path, obj]), a dict ({"path": path, "obj": obj}), or a new class structure (.path = path, .obj = obj) if it is intended to be mutable.
Breaking Part: All .items() call to .container or .m_Container is no longer needed as it is an array instead of a dict.
To avoid the compatibility issue, a list wrapper class with an .items() method that returns the list may be used in all container properties.