Add $ref support for ComboBox + some optimization#77
Merged
SaifJerbi merged 1 commit intoJsonSchema-JavaUI:devfrom Mar 11, 2018
Merged
Add $ref support for ComboBox + some optimization#77SaifJerbi merged 1 commit intoJsonSchema-JavaUI:devfrom
SaifJerbi merged 1 commit intoJsonSchema-JavaUI:devfrom
Conversation
add $ref support (external resource) for ComboBox
SaifJerbi
approved these changes
Mar 11, 2018
Member
SaifJerbi
left a comment
SaifJerbi
left a comment
There was a problem hiding this comment.
Good work to improve the code quality and remove code duplication
Member
|
Hi @almirus, |
Author
|
I do not speak English well. It may be necessary to add support $ref for all fields |
Member
|
I found the combo box and the check box documentation aren't published yet, so i will add this property in the doc and publish that ASAP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
code deduplication and add $ref support for ComboBox