Added SpotifyAPI.Core - .NET Core version of SpotifyAPI#237
Closed
ibebbs wants to merge 1 commit intoJohnnyCrazy:masterfrom
Closed
Added SpotifyAPI.Core - .NET Core version of SpotifyAPI#237ibebbs wants to merge 1 commit intoJohnnyCrazy:masterfrom
ibebbs wants to merge 1 commit intoJohnnyCrazy:masterfrom
Conversation
Author
|
Also, FYI, I just saw your 'core' branch :0( |
Owner
|
Hi, .NET Standard support has landed in 3.0.0 Please use the following NuGet Packages: Docs will be updated soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I don't really expect you to pull this as is, it's more of a FYI.
I wanted to use your (super awesome) library from a .NET Core 2.0 console application. The .NET Portability Analyzer suggested the majority of SpotifyAPI would natively run .NET Core so I quickly added a .NET Core 2.0 library project (SpotifyAPI.Core) and copied all the files from SpotifyAPI into the new project.
Nearly everything compiled first time but I had to put in an additional workaround for the
Process.Startcall inAutorizationCodeAuth. Anyway, with these changes in place, I was successfully able to use the API from .NET Core 2.0.So, you know, that's cool.
Let me know what you think and/or whether you'd like me to make further changes.
Cheers, Ian