Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

chore: release notes for v0.18.x#155

Merged
devbww merged 3 commits intogoogleapis:masterfrom
devbww:release
Feb 3, 2020
Merged

chore: release notes for v0.18.x#155
devbww merged 3 commits intogoogleapis:masterfrom
devbww:release

Conversation

@devbww
Copy link
Copy Markdown
Contributor

@devbww devbww commented Feb 3, 2020 •
edited by coryan
Loading

Also update INSTALL_GOOGLE_CLOUD_CPP_COMMON_FROM_SOURCE rules, and
google_cloud_cpp_common and google_cloud_cpp_grpc_utils ABI dumps.

This change is Reviewable

@devbww
chore: release notes for v0.18.x
34a8dac 
Also update ``INSTALL_GOOGLE_CLOUD_CPP_COMMON_FROM_SOURCE`` rules, and
``google_cloud_cpp_common`` and ``google_cloud_cpp_grpc_utils`` ABI dumps.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 3, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 3, 2020 •
edited
Loading

Codecov Report

Merging #155 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #155   +/-   ##
=======================================
  Coverage   95.66%   95.66%           
=======================================
  Files          83       83           
  Lines        3900     3900           
=======================================
  Hits         3731     3731           
  Misses        169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48cb3b4...00bf5c5. Read the comment docs.

@devbww devbww marked this pull request as ready for review February 3, 2020 21:20
coryan
coryan reviewed Feb 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @devbww, @devjgm, @mr-salty, and @scotthart)

CHANGELOG.md, line 9 at r1 (raw file):

* fix: google/cloud/grpc_utils/examples does not exist (#149)
* feat: gracefully fail adding to the `CompletionQueue` after `Shutdown` (#138)
* chore: simpler include guard style (#144)

I would say users do not care about this one and the next 2, but we can leave them.

CHANGELOG.md, line 13 at r1 (raw file):

* test: implement unit tests for async RPCs (#142)
* chore: remove `CompletionQueue` parameter to `AsyncGrpcOperation::Notify` (#136)
* feat!: change the result type for timers to StatusOr (#134)

Normally we announce breaking changes more loudly, please consider starting the changelog with:

**BREAKING CHANGES:**

* feat!: change the result type for timers to StatusOr (#134)
maybe a longer description here...., e.g. `CompletionQueue::MakeRelativeTimer` and `CompletionQueue::MakeDeadlineTimer()` now return a `future<StatusOr<std::chrono::system_clock::time_point>>`. This change is needed because now these operations may fail if the completion queue is shutdown before the timer is set.

**Other Changes:**
...

CHANGELOG.md, line 16 at r1 (raw file):

* fix: remove the redundant conditions in the `Run()` loop (#131)
* fix: crashes with non-empty CompletionQueue shutdown (#127)
* chore: move release notes to CHANGELOG.md (#128)

We typically remove chore: items as the users should not care, this one might be the exception.

@mr-salty
Copy link
Copy Markdown
Contributor

mr-salty commented Feb 3, 2020

CHANGELOG.md, line 12 at r1 (raw file):

* fix: make test not flaky (#143)
* test: implement unit tests for async RPCs (#142)
* chore: remove `CompletionQueue` parameter to `AsyncGrpcOperation::Notify` (#136)

this one is also a BREAKING CHANGE that I neglected to tag as such (and perhaps chore wasn't right either, although I don't know what to call it). I agree with Carlos' comment below about putting these in their own section (there should be examples here or in other repos)

devbww
devbww commented Feb 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@devbww devbww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, 4 unresolved discussions (waiting on @coryan, @devbww, @devjgm, and @scotthart)

CHANGELOG.md, line 9 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

I would say users do not care about this one and the next 2, but we can leave them.

Done.

CHANGELOG.md, line 13 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

Normally we announce breaking changes more loudly, please consider starting the changelog with:

**BREAKING CHANGES:**

* feat!: change the result type for timers to StatusOr (#134)
maybe a longer description here...., e.g. `CompletionQueue::MakeRelativeTimer` and `CompletionQueue::MakeDeadlineTimer()` now return a `future<StatusOr<std::chrono::system_clock::time_point>>`. This change is needed because now these operations may fail if the completion queue is shutdown before the timer is set.

**Other Changes:**
...

Done.

CHANGELOG.md, line 16 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

We typically remove chore: items as the users should not care, this one might be the exception.

Done.

devbww
devbww commented Feb 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@devbww devbww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, 4 unresolved discussions (waiting on @coryan, @devjgm, @mr-salty, and @scotthart)

CHANGELOG.md, line 12 at r1 (raw file):

Previously, mr-salty (Todd Derr) wrote…

this one is also a BREAKING CHANGE that I neglected to tag as such (and perhaps chore wasn't right either, although I don't know what to call it). I agree with Carlos' comment below about putting these in their own section (there should be examples here or in other repos)

Done.

coryan
coryan approved these changes Feb 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @devjgm, @mr-salty, and @scotthart)

mr-salty
mr-salty approved these changes Feb 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mr-salty mr-salty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @devjgm and @scotthart)

@devbww devbww merged commit 344aa08 into googleapis:master Feb 3, 2020
@devbww devbww deleted the release branch February 3, 2020 21:50
coryan pushed a commit to coryan/google-cloud-cpp that referenced this pull request Apr 24, 2020
@devbww
chore: release notes for v0.18.x (googleapis/google-cloud-cpp-common#155
6d87d6b 
)

Also update ``INSTALL_GOOGLE_CLOUD_CPP_COMMON_FROM_SOURCE`` rules, and
``google_cloud_cpp_common`` and ``google_cloud_cpp_grpc_utils`` ABI dumps.
coryan pushed a commit to coryan/google-cloud-cpp that referenced this pull request Apr 24, 2020
@devbww
chore: release notes for v0.18.x (googleapis/google-cloud-cpp-common#155
84f3de1 
)

Also update ``INSTALL_GOOGLE_CLOUD_CPP_COMMON_FROM_SOURCE`` rules, and
``google_cloud_cpp_common`` and ``google_cloud_cpp_grpc_utils`` ABI dumps.
coryan pushed a commit to coryan/google-cloud-cpp that referenced this pull request Apr 24, 2020
@devbww
chore: release notes for v0.18.x (googleapis/google-cloud-cpp-common#155
155e724 
)

Also update ``INSTALL_GOOGLE_CLOUD_CPP_COMMON_FROM_SOURCE`` rules, and
``google_cloud_cpp_common`` and ``google_cloud_cpp_grpc_utils`` ABI dumps.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devjgm devjgm Awaiting requested review from devjgm

@scotthart scotthart Awaiting requested review from scotthart

2 more reviewers

@coryan coryan coryan approved these changes

@mr-salty mr-salty mr-salty approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devbww @mr-salty @coryan @googlebot