Skip to content

test: accept independent restore output after wrapped cmd echo - #90

Merged
JavaZeroo merged 3 commits into
fix/conpty-backend-r47from
fix/workspace-echo-cr-r88
Oct 26, 2026
Merged

JavaZeroo merged 3 commits into
fix/conpty-backend-r47from
fix/workspace-echo-cr-r88

Conversation

@JavaZeroo

@JavaZeroo JavaZeroo commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

问题与修正

官方 ConPTY 的窄列 cmd 回显可能包含裸 CR/CUP。原第二轮工作区恢复已经产生独立目录输出和新提示符,运输完成判据却在回显中的 CR 提前返回 false,最终 stage1 失败。

使已含文字或编辑的回显记录保持不可信,直到真实 LF 后才重新判定独立输出。仍要求完整输出记录和新提示符;CR/CUP 碎片拼接、缺少真实输出/提示符等反例继续拒绝。原输入、8192 B 观察上限、30/40 秒期限和目录/版本/布局/几何/生命周期断言保持。

验证与范围

  • 固定原 262 B 运输重放:旧判据 false;仅删除回显中的一个 CR 后 true;再删真实输出行回到 false。修正后原运输 true,反例仍 false。
  • 同一触发断言在旧实现红、新实现绿;最终补充四条用例,红/绿测试源码身份分别记录。
  • 构建完成后正式运行原两轮 save → ordinary restore → clamped restore:六次均 exit0、未超时、Job active0/terminated0、desktop 删除,原布局和尺寸检查通过。
  • 候选 .5 / 固定官方 ConPTY 1.25.260930003 / flags24,源码 c93db58:完整 CTest 55/56,398.08 秒。shell 37 通过、3 skip,全部套件 8 项内部 skip;四项此前跳过的可选差分类实际执行。
  • 唯一 CTest 失败仍是 Vim stage59([R2][Backend] 修复 Console-width Vim stage59 与 native new-buffer 失败 #52);[R2][回归] 定位显式官方后端工作区 stage52 超时 #63/[R2][Workflow] 定位替换会话检查点的编号输出半行失败 #87 的旧原因未闭合。构建重叠的早期运行明确排除。此项修正验证器误拒绝,不宣称产品输出缺陷修复、完整后端、性能或 WindTerm 等价。
  • Standards 和 Spec 两轴实现及证据审查均无阻塞项。固定 head f2ea8d2 的两套 CI 已成功:Windows 默认/system 51/51、274.50 秒,准备检查 23/23,实际 checkout 3b115529ae8e2fc598fd0e116aa36cd612d535de;Build 与 External candidate(各 Windows/Linux)按各自配置通过,不与本地 official 结果合并成整体验收。

独立判据合同 · 审查后公开证据

Fixes #88。仅合入实验父分支 fix/conpty-backend-r47,不合入 main;父项 #47 / Draft PR #50 保持开放。

@JavaZeroo
JavaZeroo marked this pull request as ready for review October 26, 2026 21:41
@JavaZeroo
JavaZeroo merged commit 6b365b3 into fix/conpty-backend-r47 Oct 26, 2026
8 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T21:43:06.486023Z f2ea8d2 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant