Repository navigation
test: accept independent restore output after wrapped cmd echo - #90
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题与修正
官方 ConPTY 的窄列 cmd 回显可能包含裸 CR/CUP。原第二轮工作区恢复已经产生独立目录输出和新提示符,运输完成判据却在回显中的 CR 提前返回 false,最终 stage1 失败。
使已含文字或编辑的回显记录保持不可信,直到真实 LF 后才重新判定独立输出。仍要求完整输出记录和新提示符;CR/CUP 碎片拼接、缺少真实输出/提示符等反例继续拒绝。原输入、8192 B 观察上限、30/40 秒期限和目录/版本/布局/几何/生命周期断言保持。
验证与范围
c93db58:完整 CTest 55/56,398.08 秒。shell 37 通过、3 skip,全部套件 8 项内部 skip;四项此前跳过的可选差分类实际执行。f2ea8d2的两套 CI 已成功:Windows 默认/system 51/51、274.50 秒,准备检查 23/23,实际 checkout3b115529ae8e2fc598fd0e116aa36cd612d535de;Build 与 External candidate(各 Windows/Linux)按各自配置通过,不与本地 official 结果合并成整体验收。独立判据合同 · 审查后公开证据
Fixes #88。仅合入实验父分支
fix/conpty-backend-r47,不合入 main;父项 #47 / Draft PR #50 保持开放。