Skip to content

fix: wait for WSL shell after native size query (#80) - #82

Merged
JavaZeroo merged 2 commits into
fix/workspace-oracle-main-r72from
investigate/local-shell-exit-r80
Oct 26, 2026
Merged

JavaZeroo merged 2 commits into
fix/workspace-oracle-main-r72from
investigate/local-shell-exit-r80

Conversation

@JavaZeroo

@JavaZeroo JavaZeroo commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

四 shell 测试在 native 尺寸程序刚输出标记时就向 WSL 发送 exit;受控程序已观察完整 exit CR 后返回,WSL却没有退出,复现 stage6。现在仍核对四个真实尺寸,但等 WSL 同次尺寸输出后的独立新提示符再开始原顺次退出;normal_exit 仅在四会话实际回收且无错误后写入。

新增默认关闭的实际事件握手回归:native helper输出尺寸后等待宿主release,宿主先核对实际退出条件没有提前放行,再继续四shell正常退出。原WM_CHAR输入、目录/尺寸、8192B观察上限及30/40秒期限不变。实现2b85fef;证据HEAD54ed4b5。

验证:

  • 同一事件夹具保留旧条件时4.795秒红;最终握手与原两轮共3场景通过,四shell依次stage6/7/8/9 exit0、Job0/desktopgone。
  • 同源码默认/system完整CTest46/46,283.89秒;shell39方法、3skip,全套12内部skip完整分列。#72原保存/恢复方法在同次完整回归通过。
  • 原本机六次未复现、受控stage6红、旧gate红、中间全shell提示符方案的cmd stage5红全部保留;最终只约束WSL,未放宽共享oracle。
  • Standards/Spec代码、文档及原件/哈希双轴审查完成,无未处理实现问题。Build regression与External candidate均通过;Windows实际合并checkout659306b,46/46、267.48s。该hosted结果与本机默认/system记录分列。

机制与复验 · 固定证据

本PR基于#79,仅增加#80限定修正。原hosted样本缺native输入边界,是否同因仍未知,#80保持开放;不宣称产品typeahead、其他配置、真实呈现或R2全量通过。PR76环境准备超时由#81单独追踪。

@JavaZeroo
JavaZeroo marked this pull request as ready for review October 26, 2026 18:05
@JavaZeroo
JavaZeroo merged commit 21c05d0 into fix/workspace-oracle-main-r72 Oct 26, 2026
8 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T18:06:20.180233Z 54ed4b5 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant