Repository navigation
fix: synchronize shell completion and WSL native return (#72, #80) - #79
Merged
Merged
Conversation
This was referenced Oct 26, 2026
fix: wait for WSL shell after native size query (#80)
JavaZeroo
marked this pull request as ready for review
October 26, 2026 18:15
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
完成判据的两个时序缺口会让真实 shell 回归失败:PowerShell 空记录的 CR 重绘使保存判据一直拒绝已完成输出;WSL native 尺寸程序刚输出标记时,测试就可能提前发送 exit。现在允许限定的空记录 CR,并在 WSL 同次尺寸输出后等待完整新提示符再顺次退出;正常退出证据只在四会话实际回收后写入。
原 8192B 观察上限、30/40秒期限、真实尺寸/目录、WM_CHAR输入及退出/Job检查不变。加入原122B正反例与真实native-helper事件握手回归。实现与证据为#72原样移植加已合入的#82;不引入实验后端或#53的其他改动。
验证:
#72原件与三配置 · #80机制和全部阶段
#72 的限定修正已随本 PR 合入 main(af63a27e862865953d8d4ccb7ba3b5af2174f992)并结项;#80原hosted是否一定同因仍未知并保持开放。#81单独追踪另一实验PR的环境准备超时。没有完整R2、任意typeahead、其他后端、实际呈现或WindTerm性能等价声明。