Repository navigation
fix: harden R2 terminal handling and Windows regression coverage - #43
Merged
Merged
Conversation
This was referenced Oct 26, 2026
5 tasks
The old rfind completion gate was shadowed by a later OSC title containing the same marker. Match exact literal output records and a fresh prompt with an independent bounded transport oracle; preserve UTF-8 and reject incomplete controls or command echoes. Cover observed column-one CUP framing without guessing cursor rows. Keep the existing deadline, observation cap and restore workflow assertions.
JavaZeroo
marked this pull request as ready for review
October 26, 2026 05:20
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows 回归原来会因短客户区、候选宽字尾格、输入回显时序和 OSC 标题重复标记而误判。修正独立观测和夹具,补上默认核心的 ECH 与 GUI 的合法空标题处理,并让 More 捕获等待完整提示、正常退出及真实 reader EOF。
验证包括原场景 red→green、旧二进制/同字节反事实、12 项 receiver 纯测试与 14/14 原工作流、32 条恢复判定断言、真实空标题两轮和原 32 组渲染场景。最终固定
eba9cf0的 主 PR CI 为 Windows 43/43、Ubuntu 27/27;候选 PR CI 双平台成功,Windows 新 GUI 两项实际通过。主/候选 push 运行也自然成功,合计 8/8 job checks;4 个 PR ZIP 的实际 SHA 与 API digest 一致,均无_private或异常路径。云端成功 CTest 的内部 skip 数未知,候选 workflow 不是完整候选 CTest。本机候选完整 CTest 原件为 45/46,唯一错误是测试子进程未找到现有 Vim;保留该失败。任务子进程 PATH 加入现有 Git Vim 后,仅重跑原 TUI 与差分两项,6+28 子测试全部通过、无内部 skip。它不是把原完整结果改写为 46/46。
已同步 TRACKING/EVIDENCE/PLAN,保留 Kimi 已提交的 margin 实现与验证。#36 的历史 Ctrl-C、#40 的原超时、#44 的 controller 退出以及 #38 的剩余独立回归仍 OPEN;原 normal-1 的异常调用点和载荷未知,不能由新空标题复现回填。完整 R2、实际呈现、长期稳定和 WindTerm 性能等价尚未验收。
Fixes #42
Fixes #45
Fixes #46
Refs #36, #38, #40, #44