Repository navigation
feat(core): retain combined width/height resize across stages (#27) - #308
Merged
Merged
Conversation
Co-authored-by: JavaZeroo <[email protected]>
Co-authored-by: JavaZeroo <[email protected]>
Co-authored-by: JavaZeroo <[email protected]>
Co-authored-by: JavaZeroo <[email protected]>
Screen::resize_preserving prepares both frames before publishing: the height prefix moves into the primary history, surviving live rows keep their source cells and identities, and hidden live rows fit the protocol footprint. Any allocation failure publishes nothing. The transaction sweep and history-budget checks are engineering invariants, not original, Qt or performance acceptance. Co-authored-by: JavaZeroo <[email protected]>
The literal five-stage WindTerm 2.7.0 width/height observation previously passed 8/20 phases on the existing width-preserving plus legacy height route. Selecting the retained owner now passes 20/20 with 744 mapping and selection assertions, so both this replay and the transaction sweep are registered as CTest gates. Co-authored-by: JavaZeroo <[email protected]>
Record the reproduced 8/20 legacy failure, the 20/20 retained-owner replay and the allocation-failure sweeps. The report states that the default resize and Qt remain on the physical path and makes no performance or full #27/#29 acceptance claim. Co-authored-by: JavaZeroo <[email protected]>
Co-authored-by: JavaZeroo <[email protected]>
6 of 10 tasks
This was referenced Nov 3, 2026
JavaZeroo-Bot
added a commit
that referenced
this pull request
Nov 4, 2026
Limit the recorded fact to the post-resize CUP+write endpoint: no original pre-write body observation exists, so clipping/materialization cannot be attributed to resize, CUP or the write, and the sequential #308 sample is not a comparable control. Pre-write full-row retention remains only the core engineering invariant. Split the frozen original-run source identity from the later offline exporter and core-replay source identities in validation, and record the offline export correction without rerunning the original. Co-authored-by: JavaZeroo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
本 PR 恢复 #27 暂停后的推进,闭合"正文保持 + resize 联合路径"中已定位的组合尺寸缺陷。暂停时成果在旧工作区
javazero/r27-r29-resize-retention(HEAD88ace8d,另有未提交的resize_preserving)。本 PR 以远程最新 main8eec75d为基线,在独立工作区迁移所需探针、原版报告与失败回放,并提交此前未提交的Screen::resize_preserving;旧工作区未改动、未清理。未纳入:
88ace8d的隐藏主屏高度探针及其未完成离线审计 — 该切片原始严格审计仍未通过,另行处理。变更
3ca03eb/57cb70b/a73ee75/13186bf:五阶段组合尺寸原版探针、固定 ConPTY resize/输出语义记录、原版观察报告,以及旧路径的字面回放(先失败)。eb09421:新增同 ownerScreen::resize_preserving(rows, columns)。高度变化时前缀行进入主屏历史,存活行保留源 Cell/身份/软续接,两帧准备完成后一起发布;分配失败不发布。附分配失败注入与历史预算工程检查。4d24c79:回放切换到新事务,并注册resize_combined_core与resize_preserving_transaction_core两个 CTest 门禁。1eb4efc:结果报告、validation.json与 FEATURES/EVIDENCE 更新。实测验证
同一字面预期、同一 75 B 源:
13186bf,宽度保留 + 旧高度裁剪)4d24c79)环境:Windows 11 x64、VS 2022 17.12.6、MSVC 19.42.34433.0、SDK 10.0.26100.0、Release、Qt OFF、候选适配器 OFF。
完整身份、断言数与限制见 结果报告。
边界
Screen::resize与 Qt 仍走物理裁剪,正式路径 B/CD 缩放失败未被修复或豁免。流程
不自动合并、不提前关闭 issue、不触发 Codex 自动 review;合并由用户决定。提交作者为 JavaZeroo-Bot,并按配置保留共同作者 trailer。