Repository navigation
diag(shell): 转储补 closed / closer_joined (#97) - #285
Merged
Merged
Conversation
The frame is only written once closing, closed and drained hold, so the dump now shows the two flags it lacked.
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
按 #97 的下一步观测(
closing/closed/drained),把每标签页转储补全:为什么
frame.bmp只在closing_ && closed_ && drained后写出(shell.cpp:917-923)。此前转储只有closing,看不到收尾走到了哪一步;补上closed与closer_joined后,配合 #283 的frame_at_timeout,可以判断卡在:closing=falseclosing=true, closed=falseclosing=true, closed=true, frame_at_timeout=falseframe_at_timeout=true且进程未返回验证
termforge_shell构建通过。边界
Refs #97