Repository navigation
diag(shell): 超时记录 frame.bmp 是否存在 (#97) - #283
Merged
Merged
Conversation
The frame is written only after closing, closed and drained, so its presence separates an unfinished teardown from a returned process.
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
按 #97 的下一步观测（
frame.bmp是否存在 + 心跳尾部），在超时分支记录frame_at_timeout：为什么
frame.bmp只在closing_ && closed_ && drained三个条件都成立时才写出（shell.cpp:917-923）。因此期限瞬间该文件是否存在，可以区分两种形态：frame_at_timeoutfalseclosing_/closed_/drained）true此前的样本只靠人工去 artifact 里看有没有
frame.bmp；现在每次超时都自带该字段。验证
experiments.shell.test_candidate_tui在本机前后一致（5 errors，改动前后相同，缺 vim/构建产物导致），未引入回归。边界
Refs #97