Repository navigation
test(shell): 兼容 Workspace 失败前缀 (#73) - #281
Merged
Merged
Conversation
…e refs #73 The diagnostic prefix added earlier broke an exact-prefix assertion, so the regex now allows both shapes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
我在 #275 给 Workspace 失败路径加了前缀
workspace-failure mode=… what=…,导致experiments/shell/test_selection_bytes.py:202的精确前缀断言失效:这正是 PR #279 的两个 Windows 回归红项(
shell/text_actions之外的那条断言)。修改
把断言改为允许可选前缀:
"shell probe failed: (workspace-failure .*? what=)?OpenClipboard: 5"即两种形态都接受:Workspace 场景(带前缀)与 shell 直驱场景(无前缀)。
验证
python -m unittest experiments.shell.test_selection_bytes→ 10 tests OK (skipped=2)。边界
Refs #73