Repository navigation
fix(conpty): 记录制在探针侧真正生效 (#21) - #280
Merged
Merged
Conversation
JavaZeroo
force-pushed
the
fix/probe-record-flag
branch
from
October 31, 2026 10:14
aea3c77 to
b94c94b
Compare
The native exit code still gated on steady resources, so the record-only policy never took effect; the flag now relaxes only that check and the strict negative case skips when it is set.
This was referenced Oct 31, 2026
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
决策 2A 的"记录制"此前只放宽了 Python 侧的
check_sample,但原生探针自己仍把steady_resources算进clean:Server 2022 永远达不到 steady,于是探针返回 1,
run.py:172的assert result["returncode"] == 0直接失败——作业仍然是红的(本轮 run 41190293290 的windows-2022-conpty就是这样红的)。修改
probe.cpp:读取TERMFORGE_CONPTY_RECORD_HANDLES=1时,clean额外接受record_handles(只放宽这一项,其余expected_exit/capture_overflow/read_error等判定不变);test_conpty.py:正常模式的"严格拒绝"负例在该变量下不再适用(因为句柄差值已不作门槛),按开关条件执行。验证
TERMFORGE_CONPTY_RECORD_HANDLES=1 python -m unittest experiments.conpty.test_conpty→ 5 tests OK;边界
windows-2022-conpty作业设置);Refs #21