Repository navigation
diag(shell): 成功路径也记录 desktop 首次判定 (#160) - #279
Merged
Merged
Conversation
JavaZeroo
force-pushed
the
diag/desktop-settle-success
branch
from
October 31, 2026 10:14
8287f3c to
95bba92
Compare
Every run now carries a desktop_close_settle sample; previously only failing runs did, which made absence of data ambiguous.
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
按 #160 的结论（既有 3295 个 sample 里没有任何沉降记录，因为
desktop_close_settle只在失败路径写入），把首次判定也记下来：desktop_close_settle=[{elapsed_ms:0, gone:true}]；为什么
此前只有失败样本带该字段，导致"没有数据"这件事本身无法与"没跑过该路径"区分。现在每条运行都会留下首次判定，便于统计 desktop 回收的成功率与延迟分布。
验证
experiments.shell.test_watchdog_desktop_seams在本机前后结果一致（1 failure / 9 errors，改动前后相同），即本条未引入回归；这些既有失败与本次改动无关（缺synthetic.exe/ARTIFACTS环境）。边界
elapsed_ms恒为 0（首次检查即已消失），没有额外等待。Refs #160