Repository navigation
diag(shell): Workspace 失败时打印场景身份 (#73) - #275
Merged
Merged
Conversation
Workspace scenarios failed with only the caller text, so the window procedure now prints the scenario mode and the error before tearing down.
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
Workspace 场景（选择、动作、四 shell 等）的失败路径此前只保留错误文本，产物里只剩
run.py抛出的一行ValueError: shell probe failed: …，读不到是哪个场景失败。本次在
Workspace的窗口过程 catch 处补一行：为什么
#73 的复核指出：
ShellWindow::collect()的转储（stage=/input_high_water=）只对直接由 shell 驱动的场景生效，ui-selection走的是Workspace派发路径，因此那份转储对选择场景从未生效。先补最小的一行身份信息，让下次复现至少能定位到场景。验证
termforge_shell构建通过。边界
InputQueue::snapshot()、output_bytes/read_error、整屏转储需要额外的访问器，留给下一片；Refs #73