Repository navigation
diag(conpty): 失败后继续采样每一轮 (#21) - #244
Merged
Merged
Conversation
…refs #21 The host probe returned on the first failing sample, so only one steady sample per mode survived; it now records every round and still exits non-zero.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
experiments/conpty/probe.cpp的 host 模式原本在第一个失败样本上立即return 1（probe.cpp:236-238），导致每个模式只留下 1 条非 startup 样本。后果（由 #21 的核查指出）：既有的 2022 artifact 只支持「每个新宿主的第一条稳态样本 +1」，同一宿主的多轮累积从未被采样。
修改
改为：startup 检查失败仍记录，随后继续跑完全部 repeats，最后统一返回 1。这样失败批次也会留下每一轮的句柄/线程计数。
验证
termforge_conpty_probe构建通过。批次数上限（20）与返回码语义不变。边界
Refs #21