Repository navigation
diag(ime): 超时时刻记录子进程状态 (#40) - #228
Merged
Merged
Conversation
On timeout the record now carries process.poll and the partial stdout length, which separates a live child from a drained-but-late one.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 30, 2026
Open
JavaZeroo
added a commit
that referenced
this pull request
Oct 31, 2026
本分支修改了 experiments/conpty/run.py（2022 基线改为记录制），但没有同步 benchmarks/tools/results/2026-10-29-c0-settings-*/ 里 source_files_sha256 记录的哈希， 导致 Windows 回归的 windterm_c0_settings_contract 断言失败： 54fb4187…（快照记录）!= 3766879c…（工作区实际） 三处同步为当前 run.py 的 SHA-256（3766879c…）： - 2026-10-29-c0-settings-proposal/plan.json - 2026-10-29-c0-settings-reference/plan.json - 2026-10-29-c0-settings-reference/validation.json 不变的是契约本身：断言仍然要求快照与工作区一致，只是把记录更新到该分支的实际内容。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
按 #40 的下一步建议，在超时分支补两个字段（不改期限、不改判据）：
exit_at_timeout：process.poll()在期限瞬间的返回值（None= 子进程仍在运行）；partial_stdout_bytes：TimeoutExpired.output的长度（已读到的 stdout 字节数）。为什么
run 40992735979 的同类复发里，
ready_seconds=3.812、9 个检查点全部完成（worker-returned @5480 ms）、Job 0、cleanup_complete=true—— 未知已收窄到worker-returned之后（子进程退出 / stdout 排干）。这两个字段正好回答：超时时子进程是否还活着、已读了多少 stdout。验证
python -m unittest research.ime.test_hosted_inventory→ 29 tests OK（首版多算了一次time.monotonic()，破坏了 mock 的调用序列，已去掉该字段）。边界
Refs #40