Repository navigation
ci: 计时作业挂上 Node 检查点 (#144) - #227
Conversation
The dedicated timing job already reproduced the ten second timeouts without a checkpoint; it now runs node with the same preload and records whether the process ever started.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bda70a688e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| from concurrent.futures import ThreadPoolExecutor | ||
| script = "research/ui/test_raster_native_contract.js" | ||
| node = subprocess.run(["node", "--version"], capture_output=True, text=True) | ||
| preload = "node-timing-preload.js" |
There was a problem hiding this comment.
In windows-2025-node-contract-timing, preload is the bare name node-timing-preload.js, which Node resolves as a module name rather than the file written into the workspace. Node's --help describes --require as a “CommonJS module to preload”; locally, the exact bare-name invocation exits with MODULE_NOT_FOUND, while ./node-timing-preload.js succeeds. Consequently, the fixture never runs, and the report records fast nonzero exits that can still leave the job green because its final status checks only timeouts. Use an absolute path or an explicit ./ prefix so the samples actually measure the intended fixture.
AGENTS.md reference: AGENTS.md:L12-L12
Useful? React with 👍 / 👎.
内容
windows-2025-node-contract-timing（#144 的专用计时作业）现在给每次 node 调用挂上与夹具测试相同的 preload 检查点：node --require node-timing-preload.js <script>；checkpoint字段：写入内容 = Node 已加载 preload；preload never ran= 进程/加载阶段没起来。为什么现在做
该作业在 run 40990342833 里已经复现过 #144 的形状（60 次顺序调用中前两条 10.297 s / 10.140 s 超时，其余 0.062–0.250 s），但当时这条路径上没有检查点，所以拿不到"是否起来"的判据。
验证
把 YAML 内的 heredoc 提取后
python -m py_compile通过。边界
Refs #144