Repository navigation
diag(shell): readiness 记录 WSL transport 条件 (#80) - #219
Merged
Merged
Conversation
The readiness record now states whether the WSL session showed a fresh prompt after its size marker, which is the only remaining condition a stage five timeout can hit.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
shells-size-readiness.jsonl增加transport_completed字段：{"role":"wsl","columns":54,"rows":12,"settled":true,"marker_present":true,"transport_completed":false,"observed_output_tail_bytes":185}该字段直接对应
sizes_ready()里 WSL 的额外条件（尺寸标记之后必须再出现一次新提示符），因此下一次 stage 5 超时不需要推断就能看出是：marker_present=false→ 尺寸标记没到；marker_present=true且transport_completed=false→ WSL helper 之后没有新提示符（上一轮样本正是这种）。背景
上一轮样本（run 40979768991）四个会话
settled=true、marker_present=true全部满足，仍卡在 stage 5，只能推断是 WSL 的 transport 条件；本改动把它变成显式字段。边界
transport_completed恒为 true。Refs #80