Repository navigation
fix(shell): 修正 desktop 沉降路径缺失的 time 导入 (#160) - #214
Merged
Merged
Conversation
The settle path added in #199 used time.monotonic and time.sleep without the import, so the first real desktop-remained failure raised NameError instead of recording the attempts.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
采样命中：
根因是 PR #199 引入的 desktop 沉降路径用了
time.monotonic()/time.sleep()，但experiments/shell/run.py没有import time。该路径只在desktop_gone == false时执行，所以之前的绿批没有暴露；本次命中owned desktop remained时才触发。修复
补上
import time。验证
边界
desktop_close_settle记录不变）；Refs #160 #199