Repository navigation
diag(shell): stage 5 逐会话就绪诊断 (#80) - #212
Merged
Merged
Conversation
…io times out refs #80 The timeout path now writes role, grid, settled and marker presence for every tab, so a stage five failure names the session that was not ready.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
… cases refs #85 The fixture write that prepares the occupied clipboard is setup, not the product behaviour under test; a short bounded retry keeps a transient desktop holder from failing the whole scenario.
1 of 5 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
为 #80 的
ui-shells场景在超时分支增加逐会话的就绪诊断（不改期限、不改通过判据）：local_shell_size_readiness()：向shells-size-readiness.jsonl追加每条会话的role / columns / rows / settled / marker_present / observed_output_tail_bytes；scenario_shells()的 30 秒超时分支里，对四个标签各写一条，再抛出原来的超时异常。下一次同类失败可直接看出：哪个会话没有 settle、或没有出现
TF_SIZE_<cols>x<rows>尺寸标记，而不是只知道"stage 5 超时"。本地验证
cmake --build build-diag --config Release --target termforge_shell通过。边界
Refs #80 #38