Repository navigation
diagnose(shell): capture the full output stream for replay (#156) - #190
Merged
Merged
Conversation
TERMFORGE_CAPTURE_OUTPUT appends every consumed output chunk to a file, the python runner points it at the scenario artifacts, and the README documents both opt-in diagnostics. A hosted failure can then be replayed byte for byte instead of from a transport window.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
新增 opt-in 的完整输出捕获,让 hosted 失败可以逐字节回放:
TERMFORGE_CAPTURE_OUTPUT=<路径>时,把每个被消费的输出块追加写入该文件(默认不写、行为不变);execute()自动把该变量指向场景产物目录的output.bin;动机(#156 收尾遗留)
#156 已定位并关闭:选区失效由 resize 触发的 ConPTY 尾部重绘改写内容导致,
reconcile判 invalid 属正确行为。但当时的证据只有
actions-geometry-bottom.transport.bin(1071 B 的窗口片段),无法做完整回放,才导致中间几轮误判。现在每次场景都会保留完整输出流,后续同类失败可直接
Parser(..., ParseMode::recovery)回放复现。本地验证
边界
Refs #156 #38