Repository navigation
diagnose(shell): record the projection shape behind a discarded selection (#156) - #189
Merged
Merged
Conversation
…efs #156 The discard report now carries saved/current byte and column counts, so a hosted failure shows whether a row was cropped (columns differ) or rewritten (bytes differ). The branch also carries the repeat job used to reproduce the failure.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
DiscardReport携带saved_bytes/current_bytes/saved_columns/current_columns，JSONL 同步输出。windows-2025-actions-repeat（重复跑text_actions|selection_context），用于按需复现 [R2][回归] 定位默认/system的动作几何恢复后选区失效 #156。本地结果
{"schema":"termforge-selection-discard-v1","reason":"row-text-changed","row":0,"saved_bytes":23,"current_bytes":17,"saved_columns":74,"current_columns":74,"t_ms":187046484}本地（通过的那次）丢弃是
live-selected阶段的预期失效：列数相同、字节数 23→17，属内容改写。已复现的 hosted 失败（上一轮）
失败发生在
geometry-zoom75与geometry-failure之间，丢弃行号为 78；本 PR 合入后重跑同一作业即可看到该行的字节/列数差异，从而区分"裁剪"与"改写"。边界
TERMFORGE_SELECTION_DIAG时不写文件。Refs #156 #99 #73