Repository navigation
diagnose(shell): timestamp the discard and progress records (#156) - #188
Merged
Merged
Conversation
Both the selection-discard JSONL and the actions progress JSONL now carry a monotonic t_ms so a hosted discard can be ordered against the geometry phases that precede the failing check.
3 tasks
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
给选区丢弃诊断与场景阶段记录加单调时间戳，用于判定丢弃发生在哪个阶段之前/之后：
selection-discard.jsonl增加t_ms（GetTickCount64()）；actions-progress.jsonl的每条阶段记录增加t_ms；本地结果
本地一次通过运行（6.27s）里，丢弃记录在 live-selected 阶段（t=185221656），几何阶段依次是 geometry-144/192/96/zoom75/restored（t=185220140…185220703）；
也就是说本地那次丢弃发生在几何切换之后，属于场景自身"制造失效选区"的行为（紧接着是 invalidated-copy-rejected），不在几何区间内。
hosted 失败时即用这两个文件对照：若丢弃的
t_ms落在geometry-*之间，就是几何切换破坏了选区；否则另有原因。边界
TERMFORGE_SELECTION_DIAG时不写诊断文件。Refs #156