Repository navigation
diagnose(shell): record the selection row whose text changed (#156) - #187
Merged
Merged
Conversation
The discard observer now reports the affected selection row; the JSONL adds a row field, the selection contract keeps asserting the reason, and the local actions scenario logs row 0 with row-text-changed even when it passes.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
在 #186 的选区丢弃诊断上加一行信息:记录发生不一致的选区行序号。
void(*)(const char* reason, size_t row);{"schema":"termforge-selection-discard-v1","reason":"...","row":N}(row=0表示与具体行无关的分支,例如epoch-mismatch);selection_core契约同步更新;README 说明row含义。本地验证
即使场景通过,也会在几何变化过程中记录到一次 row 0 的 row-text-changed;这为判断 hosted 失败时丢弃落在哪个阶段、哪一行提供了更具体的信息。
边界
TERMFORGE_SELECTION_DIAG时不写任何文件。Refs #156