Skip to content

diagnose(shell): record the selection row whose text changed (#156) - #187

Merged
JavaZeroo merged 1 commit into
mainfrom
diag/selection-row-detail
Oct 29, 2026
Merged

JavaZeroo merged 1 commit into
mainfrom
diag/selection-row-detail

Conversation

@JavaZeroo

Copy link
Copy Markdown
Owner

内容

在 #186 的选区丢弃诊断上加一行信息:记录发生不一致的选区行序号。

  • 观察器签名变为 void(*)(const char* reason, size_t row);
  • JSONL 变为 {"schema":"termforge-selection-discard-v1","reason":"...","row":N}(row=0 表示与具体行无关的分支,例如 epoch-mismatch);
  • selection_core 契约同步更新;README 说明 row 含义。

本地验证

python -m unittest experiments.shell.test_actions.ActionWindowTest.test_actual_local_actions_twice_without_clipboard -v
Ran 1 test in 6.480s — OK
{"schema":"termforge-selection-discard-v1","reason":"row-text-changed","row":0}

即使场景通过,也会在几何变化过程中记录到一次 row 0 的 row-text-changed;这为判断 hosted 失败时丢弃落在哪个阶段、哪一行提供了更具体的信息。

边界

Refs #156

The discard observer now reports the affected selection row; the JSONL adds a row field, the selection contract keeps asserting the reason, and the local actions scenario logs row 0 with row-text-changed even when it passes.
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-29T14:42:34.966047Z
We couldn’t complete this review. Comment @codex review to try again.
2a8ef34 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@JavaZeroo
JavaZeroo merged commit 83dd169 into main Oct 29, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant