Skip to content

research(core): 保留历史内存与 H10000 Search 成本 (#164) - #176

Merged
JavaZeroo merged 1 commit into
mainfrom
research/history-memory-r164
Oct 29, 2026
Merged

JavaZeroo merged 1 commit into
mainfrom
research/history-memory-r164

Conversation

@JavaZeroo

Copy link
Copy Markdown
Owner

内容

补上 #164 最后一项里仍缺的生产内存与 H=10000 整文档 Search 观测:

  • 新增 history_memory_probe(EXCLUDE_FROM_ALL,默认不构建、不注册 CTest):每个样本一个新进程,Parser(24,80,N) 喂 N+40 行,用 K32GetProcessMemoryInfo 读工作集/私有提交,steady_clock 记录填充与整文档 Search 的耗时/步数。
  • 发布固定结果:experiments/core/results/2026-10-29-history-memory/(README + validation.json),并在 EVIDENCE 登记。

结果(H=100/1000/10000,各 3 样本)

H 保留行 命中 Search 步数 填充 µs Search µs 私有提交 前→后 每行私有增量
100 124 0(第 0 行已淘汰) 3 590–752 867–1,200 0.69→2.54 MB ~14.5 KB
1000 1024 1 21 5,120–7,839 5,916–6,023 0.67→7.69 MB ~6.9 KB
10000 10024 10 199 53,969–65,463 53,389–58,331 0.68→58.97 MB ~5.8 KB
  • 每行私有增量随 H 增大收敛到 ~5.8–6.9 KB;H=10000 私有提交约 59 MB、工作集约 61 MB。
  • 整文档 Search 在 H=10000 约 54 ms(199 步 × 4096 work),线性于行数。

明确未做

Refs #164

…164

Adds an EXCLUDE_FROM_ALL probe that reports working set, private commit, fill time and a full-document search at H=100/1000/10000 on the production Screen and TextSearch, with fixed results and evidence identity.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T10:39:50.930353Z 3ee3baf PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3ee3baf189

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


- 这是**生产** `Screen`/`TextSearch` 的观测,不是 r164 fork 的 Scan/LazyTable 对照;两者不可直接比较。
- 每行成本主要来自 `Cell` 的 `std::string text` 与完整属性结构(80 列 × 约 72 B),本轮未尝试压缩或共享存储;该数值是后续历史压缩/大历史实验的基线输入,**不是性能预算**。
- 峰值工作集等于最终工作集(没有额外瞬时峰值),但进程基线含运行时与二进制映像;每行数字取自前后差值。

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Retain peak samples before claiming no transient memory peak

The statement that peak working set equals final working set cannot be checked against the published evidence: validation.json omits peak_working for every sample, although the probe emits it. Moreover, that peak is captured before TextSearch runs, so it cannot establish the absence of a transient peak across the whole experiment. Preserve the per-sample peak values and explicitly restrict this conclusion to the fill phase, or remove the unsupported conclusion. AGENTS.md requires raw samples for every performance claim.

AGENTS.md reference: AGENTS.md:L12-L12

Useful? React with 👍 / 👎.

@JavaZeroo
JavaZeroo merged commit 29a9532 into main Oct 29, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant