Repository navigation
core: 封存行存储、结构只经 owner 发布 (#169) - #172
Merged
Merged
Conversation
…h refs #169 Screen::lines/history become private with read-only accessors; mark_order_unknown is removed because no bypass write exists any more. 23 files migrate 363 read sites, test fixtures and the r164 probe publish through publish(), and the Find overlay crops by document rank instead of numeric identity.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
本片交付
首片(#170,
85eb5a0)给了publish/locate/order_revision,但Screen::lines/history仍公开,绕过发布口的写入仍会留下陈旧 rank。本片把这条路径关掉:lines/history移入 private,新增只读口visible_lines()/history_lines()/history_size();结构只经resize/newline/activate_buffer/publish/restore_frame改变。mark_order_unknown()在存储私有后没有调用者,删掉,避免“看得到但没人该用”的旁路。selection_test3 处身份替换与 r164 乱序夹具改经publish();measure/render/trace/shell 场景与 Qt 源码同步。ShellWindow::search_overlay的可见范围裁剪与逐行覆盖由数值 ID 比较改为文档 rank(view.viewport.top + row+TextDocument::index_of)。r164 冻结研究树(
experiments/core/line_order,由prepare.py用固定源码再生)不随主线迁移:它对照的是冻结的旧screen.hpp,改动会破坏可复现性。验证(本机,隔离 worktree)
/W4无告警输出。candidate_terminal.cpp以/W4 /std:c++17独立编译 exit 0(本机未启用候选适配器;链接与运行由本 PR 的alacritty-headless作业复核)。qt-cpp-windows作业复核。证据:README · validation.json
明确未做
emit_from_id_/prune/rewind区段假设未改。Refs #169