Repository navigation
diagnose(conpty): 在记录的 CI 宿主上采样 resize 回复 refs #145 - #171
Merged
Merged
Conversation
Adds an isolated diagnostic that resizes a real system ConPTY session and immediately asks the client for its own console size, recording buffer/window dimensions, tag correlation and timing. The lifecycle probe, its oracle and its 5s wait are unchanged; the win11-local sample (200 rounds) shows no stale reply.
…refs #145 Adds a startup mode that starts a brand-new session per sample, performs the recorded ready/SIZE/ECHO/resize/SIZE sequence and records buffer, window, resize-VT and timing. Local win11: 100 sessions with no stale reply.
2800 samples across win11 and hosted windows-2025 show no stale client size, no buffer/window divergence and the resize VT always before the reply. The recorded CI failures and #145 remain open; no oracle, wait or product change.
JavaZeroo
marked this pull request as ready for review
October 29, 2026 09:02
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
experiments/conpty/resize_reply_probe.cpp/resize_reply_run.py：tag 化的系统 ConPTY resize 回复采样，同时记录 buffer 与 window 尺寸、resize VT 是否先于回复、微秒级时序；不修改原生命周期探针、其 5 秒等待或新尺寸 oracle。conpty-compat.yml（仅 workflow_dispatch）增加windows-2025-resize-replyjob：与 build.yml 同一 hosted 镜像，5×200 轮交替 resize + 5×100 次全新会话。experiments/conpty/results/2026-10-29-resize-reply-r145/（README + validation.json），并在 EVIDENCE 登记。结论
2800 个样本（hosted 2000 交替 resize + 500 全新会话，本机 200 + 100）均返回请求尺寸，buffer/window 无分歧，resize VT 全部先于回复，中位回复 8.7–16.1ms。否定“resize 后立即查询存在必然竞态”这一假设，用于收窄 #145；不关闭 #145/#38，不改变生产策略。
不声称
Refs #145 #38