Repository navigation
feat: isolate cmd tabs and verified shutdown in the Qt shell (#124) - #128
Merged
Merged
Conversation
JavaZeroo
marked this pull request as ready for review
October 28, 2026 15:30
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 28, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
正式Qt入口此前只有一个固定cmd窗口。本PR增加显式“+”、标签切换和关闭动作，每页独立C++模型、队列及固定ConPTY；关闭一页后其他会话继续运行，失败启动页保留错误。Refs #124。
两个真实cmd通过不同字面预期750/427，关闭首页后另一页继续得778并自然退出41；失败页关闭后活页继续得147。父窗口及最后标签关闭都等待模型完成、核对回收后经统一完成回调退出，失败回收返回1。
保留四条功能运行红及其修复。Spec审查另发现产品默认last-window自动退出与测试继续泵事件的缺口，真实app.exec用例以aboutToQuit前清理未完成取得1.33秒红；修订后四个app.exec边界通过，退出前各模型finished/cleanup_verified/各自Job0。targeted Qt1/1，外层Job0/26/0；Std/Spec最终0剩余。旧三案和25秒外层/35秒CTest期限不变。
固定运行源码
cf8b40b2e44f9e475cfc42b5008d46c670ff1756完整构建成功；主代理直接监督的新 CTest 50/50、退出0、325.94秒，内部12条跳过记录分列。Qt仅1项，其余49项是既有/独立诊断；Qt1.53秒、Job0/26/0，四个实际app.exec边界的退出前回收已验证。7151冻结文件run后全部匹配。此前aa068c9整轮在交接后未完成（29项完成、止于30项开始、exit未知），封存原件，不拼新50。固定结果与验证身份仅新增经审查脱敏证据；56proof/20精选身份、早期未知和原红均单列。最终两轴runtime及证据复核0剩余；后续提交只改文档和索引，不变编译输入。Hosted检查另外回读后合入。
仅固定80×24 cmd标签和程序化按键/offscreen验证；未迁移分屏、其他shell、配置恢复、动态resize、Unicode/IME或完整Find/选择，不继承八会话、真实DPI或性能验收。核心和transport实现未改。