Skip to content

Aplicar técnica de Refactorización : Introduce Assertion.  #124

Open

Description

@tyrerodr

Dentro de la clase FibonacciEvenSum se tienen comentarios para los métodos fibonacciCalculator, twoMatrixMultiplication y decompusitionInSumOfTwo. Estos comentarios representan un mal olor y son prácticamente innecesarios, ya que con la firma de dichos métodos es bastante obvia la función de cada método,

import java.lang.Math;
public class FibonacciEvenSum {
	static void evenSum(){
		int x=1, y=2, sum=0;
		while(y<4000000){
			if(y%2 == 0) sum+=y;
			y+=x;
			x=y-x;
		}
		System.out.println("The sum is " + sum);
	}

	static int calculadorFibonacci(int term){
		int y=0, x=1, aux;
		for(int i=1; i<term; i++){
			aux = y;
			y=x;
			x=x+aux;
		}
		return x;
	}

	static int[][] multiplicarDosMatrices(int matrix1[][], int matrix2[][]){
		int[][] result = new int[2][2];
		result[0][0]=matrix1[0][0] * matrix2[0][0] + matrix1[0][1] * matrix2[1][0];
		result[0][1]=matrix1[0][0] * matrix2[0][1] + matrix1[0][1] * matrix2[1][1];
		result[1][0]=matrix1[1][0] * matrix2[0][0] + matrix1[1][1] * matrix2[1][0];
		result[1][1]=matrix1[1][0] * matrix2[0][1] + matrix1[1][1] * matrix2[1][1];
		return result;
	}
	
	static int[] descomponerEnSumaDeDos(int fibonacciTerm){
		int[] result = new int[8];
		int k=7;
		for(int i=7; i>=0; i--){
			if(fibonacciTerm - Math.pow(2,i)>=0){
				result[k] = 1;
				fibonacciTerm = (int) (fibonacciTerm - Math.pow(2, i));
			}
			k--;
		}
		return result;
	}

Activity

  1. changed the title [-]Aplicar técnica de Refactorización : Rename Method[/-] [+]Aplicar técnica de Refactorización : Introduce Assertion. [/+] on Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions