Skip to content

Aplicar técnica de Refactorización : Inline Temp #123

Open

Description

@tyrerodr

En la clase DataGenerator en los métodos salary y working Generator existen campos temporales en los cuales no es necesaria su implementación, ya que son expresiones demasiado simples para ser asignado a variables concretas. Además, solo se emplearán dichas variables dentro de un algoritmo especifico, en este caso, los métodos ya mencionados

package javasmmr.zoowsome;
import java.util.Random;
import java.math.*;
public class DataGenerator {
	public String nameGenerator(){
		String[] names={"Jane","Bill","Mary","Jon","Kevin","Joey","Lilly","Cristal","Susan","Michael","Beny","Ted",
				"Jackson","Aiden","Liam","Lucas","Noah","Mason","Ethan","Caden","Jacob","Logan","Jayden","Elijah",
				"Jack","Luke","Benjamin","Alexander","James","Jayce","Caleb","Connor","William","Carter","Ryan","Oliver",
				"Matthew","Daniel"}; 
		Random randomGenerator=new Random();
		return names[randomGenerator.nextInt(38)];
	}
	
	public Long idGenerator(){
		 Random randomGenerator=new Random();
		 long randomNum = 1_000_000_000_000L + Math.abs(randomGenerator.nextInt(999_999_999)); 
		 return randomNum;
	}
	
	public BigDecimal salaryGenerator(){
		return new BigDecimal(1500);
	}
	
    public double workingHoursGenerator(){
		return 40;
    }
	
}

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions