Emit editor:open/close events from the tray itself

knolleary · knolleary · commit daed059c47e7 · 2016-05-31T23:19:43.000+01:00
diff --git a/editor/js/ui/editor.js b/editor/js/ui/editor.js
@@ -470,9 +470,6 @@ RED.editor = (function() {
 
     function showEditDialog(node) {
         var editing_node = node;
-        if (editStack.length === 0) {
-            RED.events.emit("editor:open");
-        }
         editStack.push(node);
         RED.view.state(RED.state.EDITING);
         var type = node.type;
@@ -697,10 +694,6 @@ RED.editor = (function() {
                 RED.workspaces.refresh();
                 RED.view.redraw(true);
                 editStack.pop();
-                if (editStack.length === 0) {
-                    RED.view.focus();
-                    RED.events.emit("editor:close");
-                }
             },
             show: function() {
                 if (editing_node) {
@@ -762,9 +755,6 @@ RED.editor = (function() {
             }
             editing_config_node["_"] = node_def._;
         }
-        if (editStack.length === 0) {
-            RED.events.emit("editor:open");
-        }
         editStack.push(editing_config_node);
 
         RED.view.state(RED.state.EDITING);
@@ -855,10 +845,6 @@ RED.editor = (function() {
             close: function() {
                 RED.workspaces.refresh();
                 editStack.pop();
-                if (editStack.length === 0) {
-                    RED.view.focus();
-                    RED.events.emit("editor:close");
-                }
             },
             show: function() {
                 if (editing_config_node) {
@@ -1108,9 +1094,6 @@ RED.editor = (function() {
 
     function showEditSubflowDialog(subflow) {
         var editing_node = subflow;
-        if (editStack.length === 0) {
-            RED.events.emit("editor:open");
-        }
         editStack.push(subflow);
         RED.view.state(RED.state.EDITING);
         var subflowEditor;
@@ -1254,19 +1237,13 @@ RED.editor = (function() {
                 RED.workspaces.refresh();
                 editStack.pop();
                 editing_node = null;
-                if (editStack.length === 0) {
-                    RED.view.focus();
-                    RED.events.emit("editor:close");
-                }
             },
             show: function() {
             }
         }
         RED.tray.show(trayOptions);
     }
 
-
-
     return {
         init: function() {
             RED.tray.init();
diff --git a/editor/js/ui/tray.js b/editor/js/ui/tray.js
@@ -214,6 +214,7 @@ RED.tray = (function() {
                     showTray(options);
                 },250)
             } else {
+                RED.events.emit("editor:open");
                 showTray(options);
             }
 
@@ -243,12 +244,14 @@ RED.tray = (function() {
                     if (done) {
                         done();
                     }
+                    if (stack.length === 0) {
+                        $("#header-shade").hide();
+                        $("#editor-shade").hide();
+                        $(".sidebar-shade").hide();
+                        RED.events.emit("editor:close");
+                        RED.view.focus();
+                    }
                 },250)
-                if (stack.length === 0) {
-                    $("#header-shade").hide();
-                    $("#editor-shade").hide();
-                    $(".sidebar-shade").hide();
-                }
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -214,6 +214,7 @@ RED.tray = (function() {`
`214`	`214`	`showTray(options);`
`215`	`215`	`},250)`
`216`	`216`	`} else {`
	`217`	`+ RED.events.emit("editor:open");`
`217`	`218`	`showTray(options);`
`218`	`219`	`}`
`219`	`220`
`@@ -243,12 +244,14 @@ RED.tray = (function() {`
`243`	`244`	`if (done) {`
`244`	`245`	`done();`
`245`	`246`	`}`
	`247`	`+ if (stack.length === 0) {`
	`248`	`+ $("#header-shade").hide();`
	`249`	`+ $("#editor-shade").hide();`
	`250`	`+ $(".sidebar-shade").hide();`
	`251`	`+ RED.events.emit("editor:close");`
	`252`	`+ RED.view.focus();`
	`253`	`+ }`
`246`	`254`	`},250)`
`247`		`- if (stack.length === 0) {`
`248`		`- $("#header-shade").hide();`
`249`		`- $("#editor-shade").hide();`
`250`		`- $(".sidebar-shade").hide();`
`251`		`- }`
`252`	`255`	`}`
`253`	`256`	`}`
`254`	`257`	`}`