Skip to content

Commit cc02b07

Browse files
committed
Improve edit tray button colour contrast
1 parent 2d6aac7 commit cc02b07

3 files changed

Lines changed: 53 additions & 15 deletions

File tree

editor/sass/colors.scss

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,10 @@ $typedInput-button-background: #efefef;
5555
$typedInput-button-background-hover: #ddd;
5656
$typedInput-button-background-active: #e3e3e3;
5757

58-
$editor-button-color-primary: #666;
59-
$editor-button-color-secondary: #999;
58+
$editor-button-color-primary: #eee;
59+
$editor-button-background-primary: #AD1625;
60+
$editor-button-background-primary-hover: #6E0A1E;
61+
$editor-button-color: #999;
62+
$editor-button-background: #fff;
6063

6164
$shade-color: rgba(220,220,220,0.5);

editor/sass/editor.scss

Lines changed: 28 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -76,20 +76,40 @@
7676
font-size: 14px;
7777
padding: 6px 14px;
7878
margin-right: 8px;
79-
color: $editor-button-color-primary;
79+
color: $editor-button-color;
80+
background: $editor-button-background;
81+
82+
&.primary {
83+
border-color: $editor-button-background-primary;
84+
color: $editor-button-color-primary;
85+
background: $editor-button-background-primary;
86+
87+
&:hover {
88+
border-color: $editor-button-background-primary-hover;
89+
background: $editor-button-background-primary-hover;
90+
color: $editor-button-color-primary !important;
91+
}
92+
}
93+
&:not(.disabled):hover {
94+
//color: $editor-button-color;
95+
}
96+
&.disabled {
97+
background: none;
98+
}
99+
&.disabled:focus {
100+
outline: none;
101+
}
102+
103+
104+
105+
80106
&.leftButton {
81107
float: left;
82108
margin-top: 1px;
83109
}
84110
&:not(.leftButton):not(:last-child) {
85111
margin-right: 16px;
86112
}
87-
&:not(.primary) {
88-
background: none;
89-
&:not(.disabled):hover {
90-
color: $editor-button-color-primary;
91-
}
92-
}
93113
}
94114
}
95115

@@ -108,7 +128,7 @@
108128
margin:0;
109129

110130
&:not(:last-child) {
111-
color: $editor-button-color-secondary;
131+
color: $editor-button-color;
112132
font-weight: normal;
113133

114134
&:after {

editor/sass/jquery.scss

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,21 +79,36 @@
7979
font-size: 14px;
8080
padding: 6px 14px;
8181
margin-right: 8px;
82-
color: $editor-button-color-primary;
82+
color: $editor-button-color;
83+
background: $editor-button-background;
84+
8385
&.leftButton {
8486
float: left;
8587
margin-top: 7px;
8688
}
8789
&:not(.leftButton):not(:last-child) {
8890
margin-right: 16px;
8991
}
90-
&:not(.primary) {
91-
background: none;
9292

93-
&:hover {
94-
color: $editor-button-color-primary;
93+
&.primary {
94+
border-color: $editor-button-background-primary;
95+
color: $editor-button-color-primary;
96+
background: $editor-button-background-primary;
97+
&:not(.disabled):hover {
98+
border-color: $editor-button-background-primary-hover;
99+
background: $editor-button-background-primary-hover;
100+
color: $editor-button-color-primary !important;
95101
}
96102
}
103+
&.disabled {
104+
background: none;
105+
}
106+
&.disabled {
107+
background: none;
108+
}
109+
&.disabled:focus {
110+
outline: none;
111+
}
97112
.ui-button-text {
98113
padding: 0;
99114
}

0 commit comments

Comments
 (0)