Become a thin Electron shell over jspod#2
Merged
Conversation
Drop direct deps on javascript-solid-server (pinned 120 versions behind) and mashlib-jss. Add jspod as the single server dep and spawn it as a child process (--no-open, --port, --root) instead of calling createServer in-process. Probe readiness, then load the local pod URL in the BrowserWindow. Address bar overlay now defaults to your own pod instead of an external WebID. First launch triggers jspod's bootstrap of the default app bundle.
The nav was inside the page's body, so pages with a constrained body (like jspod's welcome.html with max-width:680px + margin:2em auto) made the nav render as a half-width chip floating mid-page. Make the nav position:fixed so it spans the viewport regardless of body layout, and pad html (not body) by the nav height so the page content sits below the nav rather than under it. Padding html targets the initial containing block, which works even when body has its own auto margins for centering.
This was referenced May 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1
Summary
javascript-solid-server@^0.0.81(current upstream is0.0.201) andmashlib-jss@^0.1.1. Addjspod@^0.0.42as the single server dep.main.jsto spawn jspod as a child process (--no-open,--port,--root) instead of callingcreateServerin-process. Probehttp://localhost:<port>/until ready, thenloadURLin theBrowserWindow. Kill the child onbefore-quit.createRequire(import.meta.url).resolve('jspod')and run withprocess.execPath+ELECTRON_RUN_AS_NODE=1, so we don't rely on PATH or.binsymlinks.window.location.href(your own pod) instead of hardcodingtimbl.solidcommunity.net.Why
solid-desktopwas ~120 JSS versions behind and reinvented bootstrap logic that jspod now handles: free-port discovery, persisted JWT token-secret, auto-install of thedefaultapp bundle on first run, seeded welcome / signin / account / docs pages, rung-1me/mecredentials with off-loopback warning. Delegating to jspod keeps solid-desktop minimal and inherits jspod releases automatically.Smoke test
Confirmed manually:
npm install && npm startlaunches the Electron window, jspod boots on port 3011 against./data, the BrowserWindow lands on the seeded welcome page, the purple address bar overlay shows the current URL, andbefore-quitterminates the child cleanly.Known follow-ups
<body>flow). Will need a CSS adjustment in a follow-up — out of scope here.start(options)JS export lands upstream, solid-desktop can import it in-process and skip the child-process layer.chrome-sandboxis shipped without the SUID bit (npmcan't set it). Users hitFATAL:setuid_sandbox_host.ccuntil theysudo chown root:root && sudo chmod 4755 node_modules/electron/dist/chrome-sandboxor pass--no-sandbox. Not caused by this PR but worth documenting separately.Test plan
rm -rf node_modules && npm install && npm starton a clean checkoutdefaultbundle completes (apps appear underdata/public/apps/)Gonavigates to an external Solid URI