-
Notifications
You must be signed in to change notification settings - Fork 9
Friendly /idp landing + /idp/auth no-client_id guard (#286, PR-A) #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
melvincarvalho
merged 5 commits into
JavaScriptSolidServer:gh-pages
from
melvincarvalho:issue-286-idp-landing
Apr 22, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cc68744
Friendly /idp landing + /idp/auth no-client_id guard (#286, PR-A)
melvincarvalho ba100f8
Address Copilot review on #287
melvincarvalho 1782f0f
Address second Copilot round on #287
melvincarvalho 9df2f0b
Address third Copilot round on #287
melvincarvalho 779159e
Address fourth Copilot round on #287
melvincarvalho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The /idp/auth route handler has logic and comments referencing HEAD requests, but HEAD is not explicitly included in the route's method list (it currently relies on Fastify's auto-HEAD-from-GET behavior). To make the contract explicit and avoid future regressions if Fastify config changes (e.g., exposeHeadRoutes), add 'HEAD' to the method array (or remove the HEAD-specific logic/comment if you intend to rely on auto-HEAD).