Non-unified build fixes mid April 2020 edition

aperezdc · aperezdc · commit 26c36ca498dc · 2020-04-16T17:30:43.000Z
https://bugs.webkit.org/show_bug.cgi?id=210599 Unreviewed build fix. Source/WebCore: No new tests needed. * bindings/js/JSNavigatorCustom.cpp: Add missing JavaScriptCore/JSCJSValue.h header. (WebCore::JSNavigator::getUserMedia): Prefix with the JSC:: namespace where needed. * dom/ShadowRoot.cpp: Add missing WebAnimation.h header. * dom/SimpleRange.cpp: Add missing NodeTraversal.h header. * editing/RemoveNodePreservingChildrenCommand.cpp: Add missing Editing.h header. * page/MemoryRelease.cpp: Add missing JavaScriptCore/VM.h header. * page/PageConfiguration.cpp: Add missing UserContentURLPattern.h header. * page/scrolling/ScrollingTree.h: Add missing EventTrackingRegions.h header. * page/scrolling/ScrollingTreeLatchingController.cpp: Add missing Logging.h header. * page/scrolling/ScrollingTreeLatchingController.h: Add missing ScrollTypes.h header, and forward declaration for WebCore::PlatformWheelEvent. * workers/service/server/SWServerJobQueue.cpp: Add missing Logging.h header. Source/WebKit: * UIProcess/DeviceIdHashSaltStorage.cpp: Add missing Logging.h header. * UIProcess/Inspector/gtk/WebInspectorProxyGtk.cpp: (WebKit::WebInspectorProxy::platformSetForcedAppearance): Add missing WebCore:: namespace prefix. * UIProcess/linux/MemoryPressureMonitor.h: Add missing wtf/text/CString.h header. Canonical link: https://commits.webkit.org/223478@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260195 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
@@ -1,3 +1,25 @@
+2020-04-16  Adrian Perez de Castro  <aperez@igalia.com>
+
+        Non-unified build fixes mid April 2020 edition
+        https://bugs.webkit.org/show_bug.cgi?id=210599
+
+        Unreviewed build fix.
+
+        No new tests needed.
+
+        * bindings/js/JSNavigatorCustom.cpp: Add missing JavaScriptCore/JSCJSValue.h header.
+        (WebCore::JSNavigator::getUserMedia): Prefix with the JSC:: namespace where needed.
+        * dom/ShadowRoot.cpp: Add missing WebAnimation.h header.
+        * dom/SimpleRange.cpp: Add missing NodeTraversal.h header.
+        * editing/RemoveNodePreservingChildrenCommand.cpp: Add missing Editing.h header.
+        * page/MemoryRelease.cpp: Add missing JavaScriptCore/VM.h header.
+        * page/PageConfiguration.cpp: Add missing UserContentURLPattern.h header.
+        * page/scrolling/ScrollingTree.h: Add missing EventTrackingRegions.h header.
+        * page/scrolling/ScrollingTreeLatchingController.cpp: Add missing Logging.h header.
+        * page/scrolling/ScrollingTreeLatchingController.h: Add missing ScrollTypes.h header,
+        and forward declaration for WebCore::PlatformWheelEvent.
+        * workers/service/server/SWServerJobQueue.cpp: Add missing Logging.h header.
+
 2020-04-16  Simon Fraser  <simon.fraser@apple.com>
 
         [Async overflow scrolling] Slow-repaint overflow scroll have force their enclosing scrollers to be slow too
diff --git a/Source/WebCore/bindings/js/JSNavigatorCustom.cpp b/Source/WebCore/bindings/js/JSNavigatorCustom.cpp
@@ -28,6 +28,7 @@
 
 #include "WebCoreJSClientData.h"
 #include <JavaScriptCore/CatchScope.h>
+#include <JavaScriptCore/JSCJSValue.h>
 
 namespace WebCore {
 
@@ -37,7 +38,7 @@ void JSNavigator::visitAdditionalChildren(JSC::SlotVisitor& visitor)
 }
 
 #if ENABLE(MEDIA_STREAM)
-JSValue JSNavigator::getUserMedia(JSGlobalObject& lexicalGlobalObject, CallFrame& callFrame)
+JSC::JSValue JSNavigator::getUserMedia(JSC::JSGlobalObject& lexicalGlobalObject, JSC::CallFrame& callFrame)
 {
     auto* function = globalObject()->builtinInternalFunctions().jsDOMBindingInternals().m_getUserMediaShimFunction.get();
     ASSERT(function);
@@ -50,7 +51,7 @@ JSValue JSNavigator::getUserMedia(JSGlobalObject& lexicalGlobalObject, CallFrame
         arguments.append(callFrame.uncheckedArgument(cptr));
     ASSERT(!arguments.hasOverflowed());
     JSC::call(&lexicalGlobalObject, function, callType, callData, this, arguments);
-    return jsUndefined();
+    return JSC::jsUndefined();
 }
 #endif
 
diff --git a/Source/WebCore/dom/ShadowRoot.cpp b/Source/WebCore/dom/ShadowRoot.cpp
@@ -41,6 +41,7 @@
 #include "StyleResolver.h"
 #include "StyleScope.h"
 #include "StyleSheetList.h"
+#include "WebAnimation.h"
 #include "markup.h"
 #include <wtf/IsoMallocInlines.h>
 
diff --git a/Source/WebCore/dom/SimpleRange.cpp b/Source/WebCore/dom/SimpleRange.cpp
@@ -27,6 +27,7 @@
 #include "SimpleRange.h"
 
 #include "CharacterData.h"
+#include "NodeTraversal.h"
 #include "Range.h"
 
 namespace WebCore {
diff --git a/Source/WebCore/editing/RemoveNodePreservingChildrenCommand.cpp b/Source/WebCore/editing/RemoveNodePreservingChildrenCommand.cpp
@@ -26,6 +26,7 @@
 #include "config.h"
 #include "RemoveNodePreservingChildrenCommand.h"
 
+#include "Editing.h"
 #include "Node.h"
 #include <wtf/Assertions.h>
 
diff --git a/Source/WebCore/page/MemoryRelease.cpp b/Source/WebCore/page/MemoryRelease.cpp
@@ -51,6 +51,7 @@
 #include "StyledElement.h"
 #include "TextPainter.h"
 #include "WorkerThread.h"
+#include <JavaScriptCore/VM.h>
 #include <wtf/FastMalloc.h>
 #include <wtf/ResourceUsage.h>
 #include <wtf/SystemTracing.h>
diff --git a/Source/WebCore/page/PageConfiguration.cpp b/Source/WebCore/page/PageConfiguration.cpp
@@ -46,6 +46,7 @@
 #include "SpeechSynthesisClient.h"
 #include "StorageNamespaceProvider.h"
 #include "UserContentController.h"
+#include "UserContentURLPattern.h"
 #include "ValidationMessageClient.h"
 #include "VisitedLinkStore.h"
 #if ENABLE(WEBGL)
diff --git a/Source/WebCore/page/scrolling/ScrollingTree.h b/Source/WebCore/page/scrolling/ScrollingTree.h
@@ -27,6 +27,7 @@
 
 #if ENABLE(ASYNC_SCROLLING)
 
+#include "EventTrackingRegions.h"
 #include "PageIdentifier.h"
 #include "PlatformWheelEvent.h"
 #include "RectEdges.h"
diff --git a/Source/WebCore/page/scrolling/ScrollingTreeLatchingController.cpp b/Source/WebCore/page/scrolling/ScrollingTreeLatchingController.cpp
@@ -29,6 +29,7 @@
 #if ENABLE(ASYNC_SCROLLING)
 
 #include "FloatPoint.h"
+#include "Logging.h"
 #include "PlatformWheelEvent.h"
 #include "ScrollingThread.h"
 #include "ScrollingTree.h"
diff --git a/Source/WebCore/page/scrolling/ScrollingTreeLatchingController.h b/Source/WebCore/page/scrolling/ScrollingTreeLatchingController.h
@@ -27,13 +27,15 @@
 
 #if ENABLE(ASYNC_SCROLLING)
 
+#include "ScrollTypes.h"
 #include <wtf/Lock.h>
 #include <wtf/Markable.h>
 #include <wtf/MonotonicTime.h>
 #include <wtf/Optional.h>
 
 namespace WebCore {
 
+class PlatformWheelEvent;
 class ScrollingTree;
 
 class ScrollingTreeLatchingController {
diff --git a/Source/WebCore/workers/service/server/SWServerJobQueue.cpp b/Source/WebCore/workers/service/server/SWServerJobQueue.cpp
@@ -29,6 +29,7 @@
 #if ENABLE(SERVICE_WORKER)
 
 #include "ExceptionData.h"
+#include "Logging.h"
 #include "SWServer.h"
 #include "SWServerRegistration.h"
 #include "SWServerWorker.h"
diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
@@ -1,3 +1,16 @@
+2020-04-16  Adrian Perez de Castro  <aperez@igalia.com>
+
+        Non-unified build fixes mid April 2020 edition
+        https://bugs.webkit.org/show_bug.cgi?id=210599
+
+        Unreviewed build fix.
+
+        * UIProcess/DeviceIdHashSaltStorage.cpp: Add missing Logging.h header.
+        * UIProcess/Inspector/gtk/WebInspectorProxyGtk.cpp:
+        (WebKit::WebInspectorProxy::platformSetForcedAppearance): Add missing WebCore:: namespace
+        prefix.
+        * UIProcess/linux/MemoryPressureMonitor.h: Add missing wtf/text/CString.h header.
+
 2020-04-16  Daniel Bates  <dabates@apple.com>
 
         REGRESSION (r259762): Should always hit test for editable elements if the WKWebView is fully editable
diff --git a/Source/WebKit/UIProcess/DeviceIdHashSaltStorage.cpp b/Source/WebKit/UIProcess/DeviceIdHashSaltStorage.cpp
@@ -26,6 +26,7 @@
 #include "config.h"
 #include "DeviceIdHashSaltStorage.h"
 
+#include "Logging.h"
 #include "PersistencyUtils.h"
 
 #include <WebCore/SharedBuffer.h>
diff --git a/Source/WebKit/UIProcess/Inspector/gtk/WebInspectorProxyGtk.cpp b/Source/WebKit/UIProcess/Inspector/gtk/WebInspectorProxyGtk.cpp
@@ -332,7 +332,7 @@ bool WebInspectorProxy::platformIsFront()
     return false;
 }
 
-void WebInspectorProxy::platformSetForcedAppearance(InspectorFrontendClient::Appearance)
+void WebInspectorProxy::platformSetForcedAppearance(WebCore::InspectorFrontendClient::Appearance)
 {
     notImplemented();
 }
diff --git a/Source/WebKit/UIProcess/linux/MemoryPressureMonitor.h b/Source/WebKit/UIProcess/linux/MemoryPressureMonitor.h
@@ -29,6 +29,7 @@
 
 #include <wtf/NeverDestroyed.h>
 #include <wtf/Noncopyable.h>
+#include <wtf/text/CString.h>
 
 namespace IPC {
 class Attachment;

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@`
`28`	`28`
`29`	`29`	`#include "WebCoreJSClientData.h"`
`30`	`30`	`#include <JavaScriptCore/CatchScope.h>`
	`31`	`+#include <JavaScriptCore/JSCJSValue.h>`
`31`	`32`
`32`	`33`	`namespace WebCore {`
`33`	`34`
`@@ -37,7 +38,7 @@ void JSNavigator::visitAdditionalChildren(JSC::SlotVisitor& visitor)`
`37`	`38`	`}`
`38`	`39`
`39`	`40`	`#if ENABLE(MEDIA_STREAM)`
`40`		`-JSValue JSNavigator::getUserMedia(JSGlobalObject& lexicalGlobalObject, CallFrame& callFrame)`
	`41`	`+JSC::JSValue JSNavigator::getUserMedia(JSC::JSGlobalObject& lexicalGlobalObject, JSC::CallFrame& callFrame)`
`41`	`42`	`{`
`42`	`43`	`auto* function = globalObject()->builtinInternalFunctions().jsDOMBindingInternals().m_getUserMediaShimFunction.get();`
`43`	`44`	`ASSERT(function);`
`@@ -50,7 +51,7 @@ JSValue JSNavigator::getUserMedia(JSGlobalObject& lexicalGlobalObject, CallFrame`
`50`	`51`	`arguments.append(callFrame.uncheckedArgument(cptr));`
`51`	`52`	`ASSERT(!arguments.hasOverflowed());`
`52`	`53`	`JSC::call(&lexicalGlobalObject, function, callType, callData, this, arguments);`
`53`		`- return jsUndefined();`
	`54`	`+ return JSC::jsUndefined();`
`54`	`55`	`}`
`55`	`56`	`#endif`
`56`	`57`