Support contextual type for property assignments in JS that are not declarations (microsoft#18820)

Andy · web-flow · commit fe9129b1ab66 · 2017-10-04T09:32:09.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -13258,13 +13258,25 @@ namespace ts {
             const binaryExpression = <BinaryExpression>node.parent;
             const operator = binaryExpression.operatorToken.kind;
             if (isAssignmentOperator(operator)) {
-                // Don't do this for special property assignments to avoid circularity
-                if (getSpecialPropertyAssignmentKind(binaryExpression) !== SpecialPropertyAssignmentKind.None) {
-                    return undefined;
-                }
-
-                // In an assignment expression, the right operand is contextually typed by the type of the left operand.
                 if (node === binaryExpression.right) {
+                    // Don't do this for special property assignments to avoid circularity
+                    switch (getSpecialPropertyAssignmentKind(binaryExpression)) {
+                        case SpecialPropertyAssignmentKind.None:
+                            break;
+                        case SpecialPropertyAssignmentKind.Property:
+                            // If `binaryExpression.left` was assigned a symbol, then this is a new declaration; otherwise it is an assignment to an existing declaration.
+                            // See `bindStaticPropertyAssignment` in `binder.ts`.
+                            if (!binaryExpression.left.symbol) {
+                                break;
+                            }
+                            // falls through
+                        case SpecialPropertyAssignmentKind.ExportsProperty:
+                        case SpecialPropertyAssignmentKind.ModuleExports:
+                        case SpecialPropertyAssignmentKind.PrototypeProperty:
+                        case SpecialPropertyAssignmentKind.ThisProperty:
+                            return undefined;
+                    }
+                    // In an assignment expression, the right operand is contextually typed by the type of the left operand.
                     return getTypeOfExpression(binaryExpression.left);
                 }
             }
diff --git a/tests/cases/fourslash/codeFixUndeclaredAcrossFiles1.ts b/tests/cases/fourslash/codeFixUndeclaredAcrossFiles1.ts
@@ -23,7 +23,7 @@ verify.getAndApplyCodeFix(/*errorCode*/undefined, 0);
 verify.getAndApplyCodeFix(/*errorCode*/undefined, 0);
 
 verify.rangeIs(`
-    y: { [x: string]: any; };
+    y: {};
     m1(): any {
         throw new Error("Method not implemented.");
     }
diff --git a/tests/cases/fourslash/completionsJsPropertyAssignment.ts b/tests/cases/fourslash/completionsJsPropertyAssignment.ts
@@ -0,0 +1,10 @@
+/// <reference path="fourslash.ts" />
+
+// @allowJs: true
+
+// @Filename: /a.js
+/////** @type {{ p: "x" | "y" }} */
+////const x = { p: "x"  };
+////x.p = "/**/";
+
+verify.completionsAt("", ["x", "y"]);

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ verify.getAndApplyCodeFix(/errorCode/undefined, 0);`
`23`	`23`	`verify.getAndApplyCodeFix(/errorCode/undefined, 0);`
`24`	`24`
`25`	`25`	verify.rangeIs(`
`26`		`- y: { [x: string]: any; };`
	`26`	`+ y: {};`
`27`	`27`	`m1(): any {`
`28`	`28`	`throw new Error("Method not implemented.");`
`29`	`29`	`}`