JS Prototypes WIP

RyanCavanaugh · RyanCavanaugh · commit fabc43d0d401 · 2015-12-04T14:11:56.000-08:00
diff --git a/src/compiler/binder.ts b/src/compiler/binder.ts
@@ -1367,42 +1367,31 @@ namespace ts {
         }
 
         function bindThisPropertyAssignment(node: BinaryExpression) {
+            // Declare a 'member' in case it turns out the container was an ES5 class
             if (container.kind === SyntaxKind.FunctionExpression || container.kind === SyntaxKind.FunctionDeclaration) {
                 container.symbol.members = container.symbol.members || {};
-                declareClassMember(node, SymbolFlags.Property, SymbolFlags.PropertyExcludes);
+                declareSymbol(container.symbol.members, container.symbol, node, SymbolFlags.Property, SymbolFlags.PropertyExcludes);
             }
         }
 
         function bindPrototypePropertyAssignment(node: BinaryExpression) {
-            // We saw a node of the form 'x.prototype.y = z'.
-            // This does two things: turns 'x' into a constructor function, and
-            // adds a member 'y' to the result of that constructor function
-            // Get 'x', the class
-            const classId = <Identifier>(<PropertyAccessExpression>(<PropertyAccessExpression>node.left).expression).expression;
+            // We saw a node of the form 'x.prototype.y = z'. Declare a 'member' y on x if x was a function.
 
-            // Look up the function in the local scope, since prototype assignments should immediately
+            // Look up the function in the local scope, since prototype assignments should
             // follow the function declaration
+            const classId = <Identifier>(<PropertyAccessExpression>(<PropertyAccessExpression>node.left).expression).expression;
             const funcSymbol = container.locals[classId.text];
-            if (!funcSymbol) {
+            if (!funcSymbol || !(funcSymbol.flags & SymbolFlags.Function)) {
                 return;
             }
 
-            // The function is now a constructor rather than a normal function
-            if (!funcSymbol.inferredConstructor) {
-                // Have the binder set up all the related class symbols for us
-                declareSymbol(container.locals, funcSymbol, funcSymbol.valueDeclaration, SymbolFlags.Class, SymbolFlags.None);
-                // funcSymbol.members = funcSymbol.members || {};
-                funcSymbol.members["__constructor"] = funcSymbol;
-                funcSymbol.inferredConstructor = true;
+            // Set up the members collection if it doesn't exist already
+            if (!funcSymbol.members) {
+                funcSymbol.members = {};
             }
 
-            // Get the exports of the class so we can add the method to it
-            const funcExports = declareSymbol(funcSymbol.exports, funcSymbol, <PropertyAccessExpression>(<PropertyAccessExpression>node.left).expression, SymbolFlags.ObjectLiteral | SymbolFlags.Property, SymbolFlags.None);
-
-            // Declare the method
-            declareSymbol(funcExports.members, funcExports, <PropertyAccessExpression>node.left, SymbolFlags.Method, SymbolFlags.None);
-            // and on the members of the function so it appears in 'prototype'
-            declareSymbol(funcSymbol.members, funcSymbol, <PropertyAccessExpression>node.left, SymbolFlags.Method, SymbolFlags.PropertyExcludes);
+            // Declare the method/property
+            declareSymbol(funcSymbol.members, funcSymbol, <PropertyAccessExpression>node.left, SymbolFlags.Property, SymbolFlags.PropertyExcludes);
         }
 
         function bindCallExpression(node: CallExpression) {
diff --git a/src/compiler/types.ts b/src/compiler/types.ts
@@ -1985,7 +1985,6 @@ namespace ts {
         /* @internal */ parent?: Symbol;        // Parent symbol
         /* @internal */ exportSymbol?: Symbol;  // Exported symbol associated with this symbol
         /* @internal */ constEnumOnlyModule?: boolean; // True if module contains only const enums or other modules with only const enums
-        /* @internal */ inferredConstructor?: boolean;       // A function promoted to constructor as the result of a prototype property assignment
     }
 
     /* @internal */

Original file line number	Diff line number	Diff line change
`@@ -1985,7 +1985,6 @@ namespace ts {`
`1985`	`1985`	`/* @internal */ parent?: Symbol; // Parent symbol`
`1986`	`1986`	`/* @internal */ exportSymbol?: Symbol; // Exported symbol associated with this symbol`
`1987`	`1987`	`/* @internal */ constEnumOnlyModule?: boolean; // True if module contains only const enums or other modules with only const enums`
`1988`		`- /* @internal */ inferredConstructor?: boolean; // A function promoted to constructor as the result of a prototype property assignment`
`1989`	`1988`	`}`
`1990`	`1989`
`1991`	`1990`	`/* @internal */`