fix(36102): fix extra new line in Organize Imports (microsoft#36911)

sacgrover · web-flow · commit bff0ddc94187 · 2020-03-12T17:51:48.000-04:00
Organize Imports was inserting extra newline. Fixes microsoft#36102
diff --git a/src/services/textChanges.ts b/src/services/textChanges.ts
@@ -889,7 +889,9 @@ namespace ts.textChanges {
                 : format(change.node);
             // strip initial indentation (spaces or tabs) if text will be inserted in the middle of the line
             const noIndent = (options.preserveLeadingWhitespace || options.indentation !== undefined || getLineStartPositionForPosition(pos, sourceFile) === pos) ? text : text.replace(/^\s+/, "");
-            return (options.prefix || "") + noIndent + (options.suffix || "");
+            return (options.prefix || "") + noIndent
+                 + ((!options.suffix || endsWith(noIndent, options.suffix))
+                    ? "" : options.suffix);
         }
 
         function getFormatCodeSettingsForWriting({ options }: formatting.FormatContext, sourceFile: SourceFile): FormatCodeSettings {
