Fix scope of @typedef references (microsoft#16718)

Andy · web-flow · commit 2ccfe502f7b8 · 2017-06-28T13:30:23.000-07:00
* Fix scope of @typedef references * Remove unused variables
diff --git a/src/services/utilities.ts b/src/services/utilities.ts
@@ -275,6 +275,13 @@ namespace ts {
     }
 
     export function getContainerNode(node: Node): Declaration {
+        if (node.kind === SyntaxKind.JSDocTypedefTag) {
+            // This doesn't just apply to the node immediately under the comment, but to everything in its parent's scope.
+            // node.parent = the JSDoc comment, node.parent.parent = the node having the comment.
+            // Then we get parent again in the loop.
+            node = node.parent.parent;
+        }
+
         while (true) {
             node = node.parent;
             if (!node) {
diff --git a/tests/cases/fourslash/findAllRefsJsDocTypeDef_js.ts b/tests/cases/fourslash/findAllRefsJsDocTypeDef_js.ts
@@ -0,0 +1,20 @@
+/// <reference path='fourslash.ts'/>
+
+// Tests that the scope of @typedef is not just the node immediately below it.
+
+// @allowJs: true
+
+// @Filename: /a.js
+/////** @typedef {number} [|{| "isWriteAccess": true, "isDefinition": true |}T|] */
+////
+/////**
+//// * @return {[|T|]}
+//// */
+////function f(obj) { return 0; }
+////
+/////**
+//// * @return {[|T|]}
+//// */
+////function f2(obj) { return 0; }
+
+verify.singleReferenceGroup("type T = number");
