jsdoc template tags might be unmatched (microsoft#32936)

sandersn · web-flow · commit 2b8ccf40aeb0 · 2019-08-16T13:39:57.000-07:00
* jsdoc template tags might be unmatched

* Update fourslash test
diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts
@@ -2343,7 +2343,7 @@ namespace ts {
     export function getTypeParameterFromJsDoc(node: TypeParameterDeclaration & { parent: JSDocTemplateTag }): TypeParameterDeclaration | undefined {
         const name = node.name.escapedText;
         const { typeParameters } = (node.parent.parent.parent as SignatureDeclaration | InterfaceDeclaration | ClassDeclaration);
-        return find(typeParameters!, p => p.name.escapedText === name);
+        return typeParameters && find(typeParameters, p => p.name.escapedText === name);
     }
 
     export function hasRestParameter(s: SignatureDeclaration | JSDocSignature): boolean {
diff --git a/tests/cases/fourslash/jsDocFunctionSignatures13.ts b/tests/cases/fourslash/jsDocFunctionSignatures13.ts
@@ -0,0 +1,10 @@
+///<reference path="fourslash.ts" />
+//// /**
+////  * @template {string} K/**/ a golden opportunity
+////  */
+//// function Multimap(iv) {
+//// };
+
+
+goTo.marker('');
+verify.quickInfoIs("any");

Original file line number	Diff line number	Diff line change
`@@ -2343,7 +2343,7 @@ namespace ts {`
`2343`	`2343`	`export function getTypeParameterFromJsDoc(node: TypeParameterDeclaration & { parent: JSDocTemplateTag }): TypeParameterDeclaration \| undefined {`
`2344`	`2344`	`const name = node.name.escapedText;`
`2345`	`2345`	`const { typeParameters } = (node.parent.parent.parent as SignatureDeclaration \| InterfaceDeclaration \| ClassDeclaration);`
`2346`		`- return find(typeParameters!, p => p.name.escapedText === name);`
	`2346`	`+ return typeParameters && find(typeParameters, p => p.name.escapedText === name);`
`2347`	`2347`	`}`
`2348`	`2348`
`2349`	`2349`	`export function hasRestParameter(s: SignatureDeclaration \| JSDocSignature): boolean {`