Implement LatCom#42
Merged
Merged
Conversation
|
This pull request introduces 9 alerts when merging 5862bc4 into c200b55 - view on LGTM.com new alerts:
|
|
This pull request introduces 7 alerts when merging d1a6767 into c200b55 - view on LGTM.com new alerts:
|
Some typos fixes, markdown new line conformance, minor style changes.
Better readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements LatCom with minimal performance (speed/memory) impact for non-LatCom users.
Implementation required only to apply current frame LatCom, e.g. the next frame is already handled by just reading of the server. Current frame LatCom is done by saving the current LatCom affected value in a Cache object that invalidates on the next frame (e.g. only valid on the frame it was changed).
Added:
CommandTempclass, inspired by CommandTemp.hCache<T>class (and subclasses) which stores a LatCom valuePlayer/Unitselfclass/containers which have a collection of internal Player/Unit values that are affected by LatComLatencyListenertestclass which gives some debug info (also tested in BWMirror to compare values with JBWAPI)Non-LatCom users should not be negatively affected because the "self" instances get lazily instanciated. (e.g. only if you actually use latcom)
No difference anymore between BWMirror & JBWAPI both using LatCom
closes #6