Add WP AI Client - #1
Draft
JasonTheAdams wants to merge 43 commits into
Draft
Conversation
felixarntz
reviewed
Feb 6, 2026
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
Looks great so far! A few early notes.
| @@ -0,0 +1,336 @@ | |||
| #!/usr/bin/env bash | |||
| # | |||
| # Installer script for bundling wordpress/php-ai-client into WordPress Core. | |||
felixarntz
reviewed
Feb 6, 2026
JasonTheAdams
force-pushed
the
add/wp-ai-client
branch
from
February 11, 2026 16:37
479ebb4 to
a5bd792
Compare
This adjusts the test coverage workflow to run for any change to a PHP file in a pull request. This is not meant to be included in the final merge, but aims to help gauge the test coverage changes this merge would result in.
t-hamano
pushed a commit
that referenced
this pull request
Jul 10, 2026
…om `previous_posts()`. The `esc_url()` function expects to a string for `$url` parameter. There is no input validation within that function. The function contains a `ltrim()` which also expects a string. Passing `null` to this parameter results in `Deprecated: ltrim(): Passing null to parameter #1 ($string) of type string is deprecated` notice on PHP 8.1+. Tracing the stack back, a `null` is being passed to it within `previous_posts()` when `get_previous_posts_page_link()` returns `null` (it can return a string or `null`). On PHP 7.0 to PHP 8.x, an empty string is returned from `esc_url()` when `null` is passed to it. The change in this changeset avoids the deprecation notice by not invoking `esc_url()` when `get_previous_posts_page_link()` returns `null` and instead sets the `$output` to an empty string, thus maintaining the same behavior as before (minus the deprecation notice). Adds a test to validate an empty string is returned and the absence of the deprecation (when running on PHP 8.1+). Follow-up to [9632], [11383], [56740]. Props dd32, alexodiy. Fixes #64864. git-svn-id: https://develop.svn.wordpress.org/trunk@62034 602fd350-edb4-49c9-b593-d223f7449a82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A temporary place for this to review prior to the core PR.